Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix](vec) Fix allow create mv using to_bitmap() on negative value columns when enable_vectorized_alter_table is true #13448

Merged
merged 5 commits into from
Oct 19, 2022

Conversation

yangzhg
Copy link
Member

@yangzhg yangzhg commented Oct 18, 2022

Proposed changes

Issue Number: close #13447

Problem summary

Describe your changes.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions github-actions bot added area/planner Issues or PRs related to the query planner area/sql/function Issues or PRs related to the SQL functions area/vectorization labels Oct 18, 2022
@yangzhg yangzhg changed the title [Bugfix](vec) Fix all create mv using to_bitmap() on negative value columns when enable_vectorized_alter_table is ture [Bugfix](vec) Fix all create mv using to_bitmap() on negative value columns when enable_vectorized_alter_table is true Oct 19, 2022
Copy link
Contributor

@cambyzju cambyzju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yangzhg yangzhg merged commit 0b368fb into apache:master Oct 19, 2022
ChPi pushed a commit to ChPi/incubator-doris that referenced this pull request Oct 20, 2022
…olumns when enable_vectorized_alter_table is true (apache#13448)

* [Bugfix] add negtive value check when create mv using vec
@yangzhg yangzhg changed the title [Bugfix](vec) Fix all create mv using to_bitmap() on negative value columns when enable_vectorized_alter_table is true [Bugfix](vec) Fix allow create mv using to_bitmap() on negative value columns when enable_vectorized_alter_table is true Oct 21, 2022
morningman pushed a commit that referenced this pull request Oct 27, 2022
…l cause count distinct result incorrect (#13700)

cherry-pick #13667 #13448
@yiguolei yiguolei mentioned this pull request Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/planner Issues or PRs related to the query planner area/sql/function Issues or PRs related to the SQL functions area/vectorization dev/merged-1.1.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Create MV using function bitmap_union(to_bitmap(col)) on column with negative values will not fail
4 participants