Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](planner) inlineView alias error #13600

Merged
merged 3 commits into from
Oct 26, 2022
Merged

Conversation

englefly
Copy link
Contributor

Proposed changes

set alias for inlineViewAnalyzaer, and check alias name when resolveColumnRef()

Issue Number: 13431
#13431

Problem summary

Describe your changes.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions github-actions bot added area/planner Issues or PRs related to the query planner kind/test labels Oct 24, 2022
jackwener
jackwener previously approved these changes Oct 25, 2022
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 25, 2022
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Oct 25, 2022
Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei yiguolei merged commit e5b33ab into apache:master Oct 26, 2022
@dataalive dataalive mentioned this pull request Oct 26, 2022
3 tasks
@morningman morningman added the usercase Important user case type label label Oct 26, 2022
englefly added a commit to englefly/incubator-doris that referenced this pull request Oct 26, 2022
morningman pushed a commit that referenced this pull request Oct 27, 2022
@Wilson-BT Wilson-BT mentioned this pull request Oct 27, 2022
3 tasks
@yiguolei yiguolei mentioned this pull request Nov 1, 2022
@englefly englefly deleted the CIR-815 branch December 3, 2022 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/planner Issues or PRs related to the query planner dev/merged-1.1.4 kind/test reviewed usercase Important user case type label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants