Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](tcmalloc_gc) optimize policy of tcmalloc gc #14777

Merged
merged 1 commit into from
Dec 3, 2022

Conversation

dataroaring
Copy link
Contributor

@dataroaring dataroaring commented Dec 2, 2022

Release memory when memory pressure is above pressure limit and keep at least 2% memory as tcmalloc cache.

Proposed changes

Issue Number: close #xxx

Problem summary

Describe your changes.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

Release memory when memory pressure is above pressure limit and
keep at lease 2% memory as tcmalloc cache.
Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 3, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2022

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2022

PR approved by anyone and no changes requested.

@yiguolei yiguolei merged commit d132483 into apache:branch-1.1-lts Dec 3, 2022
@yiguolei yiguolei mentioned this pull request Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/1.1.5-merged reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants