Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](csv-reader) fix be crash when reading invalid value #14951

Merged
merged 2 commits into from
Dec 10, 2022

Conversation

morningman
Copy link
Contributor

@morningman morningman commented Dec 8, 2022

Proposed changes

Issue Number: close #xxx

Problem summary

when reading text format hive table with invalid value format, be may crash

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@morningman
Copy link
Contributor Author

test will be added in #14808

@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2022

clang-tidy review says "All clean, LGTM! 👍"

@hello-stephen
Copy link
Contributor

hello-stephen commented Dec 8, 2022

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 36.68 seconds
load time: 463 seconds
storage size: 17123356282 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221209024847_clickbench_pr_60603.html

@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2022

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 10, 2022
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. area/vectorization dev/1.2.1-merged reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants