[Improvement](JSONB) improve performance JSONB initial json parsing using simdjson #15219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/sql/function
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
xiaokang
force-pushed
the
simdjson_for_jsonb
branch
2 times, most recently
from
7d90d79
to
0890799
Compare
|
TeamCity pipeline, clickbench performance test result: |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
xiaokang
force-pushed
the
simdjson_for_jsonb
branch
from
4e91c95
to
b2c6960
Compare
github-actions
bot
removed
the
approved
xiaokang
force-pushed
the
simdjson_for_jsonb
branch
from
b2c6960
to
28d2d85
Compare
xiaokang
force-pushed
the
simdjson_for_jsonb
branch
from
28d2d85
to
3f31dc3
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
morningman
pushed a commit
that referenced
this pull request
Dec 29, 2022
…sing simdjson (#15219) test data: https://data.gharchive.org/2020-11-13-18.json.gz, 2GB, 197696 lines before: String 13s vs. JSONB 28s after: String 13s vs. JSONB 16s **NOTICE: simdjson need to be patched since BOOL is conflicted with a macro BOOL defined in odbc sqltypes.h**
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
Problem summary
Describe your changes.
test data: https://data.gharchive.org/2020-11-13-18.json.gz, 2GB, 197696 lines
before: String 13s vs. JSONB 28s
after: String 13s vs. JSONB 16s
NOTICE: simdjson need to be patched since BOOL is conflicted with a macro BOOL defined in odbc sqltypes.h
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...