Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature](load) stream load trim double quotes for csv #15241

Merged
merged 1 commit into from
Dec 26, 2022
Merged

[feature](load) stream load trim double quotes for csv #15241

merged 1 commit into from
Dec 26, 2022

Conversation

liaoxin01
Copy link
Contributor

Proposed changes

Issue Number: close #xxx

Problem summary

Describe your changes.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions github-actions bot added area/load Issues or PRs related to all kinds of load area/planner Issues or PRs related to the query planner area/vectorization labels Dec 21, 2022
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions github-actions bot added the kind/docs Categorizes issue or PR as related to documentation. label Dec 21, 2022
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@hello-stephen
Copy link
Contributor

hello-stephen commented Dec 21, 2022 •
edited
Loading

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.02 seconds
load time: 670 seconds
storage size: 17123108145 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221223054136_clickbench_pr_67584.html

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

dataroaring
dataroaring approved these changes Dec 26, 2022
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit bf71943 into apache:master Dec 26, 2022
morningman pushed a commit that referenced this pull request Dec 26, 2022
@liaoxin01 @morningman
[feature](load) stream load trim double quotes for csv (#15241)
681155c
@morningman morningman mentioned this pull request Dec 30, 2022
Open
@morningman morningman mentioned this pull request Feb 27, 2023
Closed
3 tasks
@liaoxin01 liaoxin01 deleted the csv_quotes branch February 6, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dataroaring dataroaring dataroaring approved these changes

Assignees
No one assigned
Labels
area/load Issues or PRs related to all kinds of load area/planner Issues or PRs related to the query planner area/vectorization dev/1.2.1-merged kind/docs Categorizes issue or PR as related to documentation. kind/test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@liaoxin01 @hello-stephen @dataroaring @morningman