[Improvement](multi-catalog) support hive external tables which store data on tencent chdfs #15297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/planner
morningman
reviewed
Dec 22, 2022
fe/fe-core/src/main/java/org/apache/doris/catalog/BrokerMgr.java
Outdated
Show resolved
Hide resolved
|
TeamCity pipeline, clickbench performance test result: |
morningman
reviewed
Dec 24, 2022
| .getBroker(brokerDesc.getName(), selectedBackend.getHost()); | ||
| } catch (AnalysisException e) { | ||
| throw new UserException(e.getMessage()); | ||
| FsBroker broker = Env.getCurrentEnv().getBrokerMgr().getAnyAliveBroker(); |
There was a problem hiding this comment.
Why discard the selectedBackend attribute?
It is useful for multi load.
There was a problem hiding this comment.
oh, my fault, I'm careless
|
@morningman please review, thx |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
Yulei-Yang
added a commit
to Yulei-Yang/doris
that referenced
this pull request
Dec 26, 2022
… data on tencent chdfs (apache#15297) * support read hive table whichs store data on tencent chdfs in multi-catalog
morningman
pushed a commit
that referenced
this pull request
Dec 26, 2022
… data on tencent chdfs (#15297) * support read hive table whichs store data on tencent chdfs in multi-catalog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
Problem summary
Describe your changes.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...