Add strict mode in Routine load, Stream load and Mini load #1677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imay
requested changes
Aug 20, 2019
gensrc/thrift/FrontendService.thrift
Outdated
| @@ -522,7 +522,8 @@ struct TStreamLoadPutRequest { | |||
| 15: optional string partitions | |||
| 16: optional i64 auth_code | |||
| 17: optional bool negative | |||
| 18: optional i32 timeout | |||
| 18: optional bool strictMode | |||
| 19: optional i32 timeout | |||
There was a problem hiding this comment.
Don't modify the index of old field. If you change the index, this may not compatible with old format
| @@ -1160,6 +1169,10 @@ public void readFields(DataInput in) throws IOException { | |||
|
|
|||
| origStmt = Text.readString(in); | |||
|
|
|||
| if (Catalog.getCurrentCatalogJournalVersion() >= FeMetaVersion.VERSION_59) { | |||
| strictMode = in.readBoolean(); | |||
There was a problem hiding this comment.
If you make all old routine load job to strict mode. This may cause many data to be filtered
| @@ -57,6 +57,7 @@ | |||
| private String partitions; | |||
| private String path; | |||
| private boolean negative; | |||
| private boolean strictMode = RoutineLoadJob.DEFAULT_STRICT_MODE; | |||
There was a problem hiding this comment.
Why put this DEFAULT_STRICT_MODE in RoutineLoadJob?
| @@ -105,6 +105,7 @@ | |||
| .add(MAX_BATCH_INTERVAL_SEC_PROPERTY) | |||
| .add(MAX_BATCH_ROWS_PROPERTY) | |||
| .add(MAX_BATCH_SIZE_PROPERTY) | |||
| .add(LoadStmt.STRICT_MODE) | |||
There was a problem hiding this comment.
should we update our Document about this property?
EmmyMiao87
force-pushed
the
strict_mode
branch
from
1c370a1
to
239467e
Compare
Closed
SWJTU-ZhangLei
pushed a commit
to SWJTU-ZhangLei/incubator-doris
that referenced
this pull request
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.