Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](load) fix cancel load failed because Job could not be cancelled… #17730

Merged
merged 1 commit into from Sep 3, 2023

Conversation

mymeiyi
Copy link
Contributor

@mymeiyi mymeiyi commented Mar 13, 2023

… when job is finished or cancelled

Proposed changes

Issue Number: close #xxx

Problem summary

Label can be reused if the previous load is failed. But when cancel a retry load, I got the following error:

mysql> cancel load where label = 'load_l2';
ERROR 1105 (HY000): errCode = 2, detailMessage = Cancel load job [49114] fail, label=[load_l2] failed msg=errCode = 2, detailMessage = Job could not be cancelled when job is finished or cancelled

Checklist(Required)

  • Does it affect the original behavior
  • Has unit tests been added
  • Has document been added or modified
  • Does it need to update dependencies
  • Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions github-actions bot added the area/load Issues or PRs related to all kinds of load label Mar 13, 2023
@mymeiyi
Copy link
Contributor Author

mymeiyi commented Mar 13, 2023

run buildall

@morningman
Copy link
Contributor

Why change this behavior?

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring
Copy link
Contributor

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2023

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2023

PR approved by anyone and no changes requested.

@hello-stephen
Copy link
Contributor

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.5 seconds
stream load tsv: 532 seconds loaded 74807831229 Bytes, about 134 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.1 seconds inserted 10000000 Rows, about 343K ops/s
storage size: 17161910421 Bytes

@dataroaring dataroaring merged commit d367e3c into apache:master Sep 3, 2023
24 of 25 checks passed
xiaokang pushed a commit that referenced this pull request Sep 5, 2023
@mymeiyi mymeiyi deleted the fix-cancel-load branch September 18, 2023 09:59
@xiaokang xiaokang mentioned this pull request Sep 28, 2023
@xiaokang xiaokang mentioned this pull request Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. area/load Issues or PRs related to all kinds of load dev/2.0.2-merged kind/behavior-changed reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants