Support table comment and column comment for view #1799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1. LGTM. Please add a UT for this PR. |
OK |
imay
requested changes
Sep 15, 2019
| [BROKER PROPERTIES ("key"="value", ...)]; | ||
| [PROPERTIES ("key"="value", ...)] | ||
| [BROKER PROPERTIES ("key"="value", ...)] | ||
| [COMMENT "table comment"]; |
There was a problem hiding this comment.
To comply with mysql, comment should locate before partition define. Both Comment and Engine are table options. Here is the reference.
morningman
force-pushed
the
support_table_comment
branch
from
70ec33c
to
e731929
Compare
Closed
SWJTU-ZhangLei
pushed a commit
to SWJTU-ZhangLei/incubator-doris
that referenced
this pull request
Jul 25, 2023
…fied with `mysql -D` (apache#1799)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See
help create tableandhelp create viewfor help.Sett
help show full columnsandhelp show table statusto view comment.