Reduce memory usage of View object #1878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imay
reviewed
Sep 25, 2019
| @@ -5126,13 +5126,6 @@ public void createView(CreateViewStmt stmt) throws DdlException { | |||
| View newView = new View(tableId, tableName, columns); | |||
| newView.setComment(stmt.getComment()); | |||
| newView.setInlineViewDef(stmt.getInlineViewDef()); | |||
| newView.setOriginalViewDef(stmt.getInlineViewDef()); | |||
| try { | |||
| newView.init(); | |||
There was a problem hiding this comment.
Do we need to keep this init in order to return parse error ASAP?
There was a problem hiding this comment.
Actually, I don't know why it throws an exception here. the stmt string comes from QueryStmt.toSql()...
So there should be no exception thrown anymore.
There was a problem hiding this comment.
Maybe there is some bug in our toSql() implementation
SWJTU-ZhangLei
pushed a commit
to SWJTU-ZhangLei/incubator-doris
that referenced
this pull request
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE #1877
ISSUE #1881