[fix](create table) modify varchar default length 1 to 65533 #21302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/planner
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
|
@hubgeter code format is wrong, pls fix it, |
github-actions
bot
removed
the
approved
hubgeter
force-pushed
the
fix-varchar-len
branch
from
9e63d95
to
311bb3f
Compare
|
应该OK了吧😭 |
|
run buildall |
|
run p0 |
|
run ut |
|
run buildall |
|
run ut |
hubgeter
force-pushed
the
fix-varchar-len
branch
from
6b3ad80
to
4f98174
Compare
|
run buildall |
kaka11chen
approved these changes
Jul 10, 2023
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
LGTM |
xiaokang
pushed a commit
that referenced
this pull request
Jul 11, 2023
*modify archer default length 1 to varchar.max.length , when create table.*
```mysql
create table t2 (
k1 CHAR,
K2 CHAR(10) ,
K3 VARCHAR ,
K4 VARCHAR(1024) )
duplicate key (k1)
distributed by hash(k1) buckets 1
properties('replication_num' = '1');
desc t2;
```
| Field | Type | Null | Key | Default | Extra |
| -- |--|--| -| -| -|
| k1 | CHAR(1) | Yes | true | NULL | |
| K2 | CHAR(10) | Yes | false | NULL | NONE |
| K3 | VARCHAR(65533) | Yes | false | NULL | NONE |
| K4 | VARCHAR(1024) | Yes | false | NULL | NONE |
BiteTheDDDDt
pushed a commit
to BiteTheDDDDt/incubator-doris
that referenced
this pull request
Jul 14, 2023
…21302) *modify archer default length 1 to varchar.max.length , when create table.* ```mysql create table t2 ( k1 CHAR, K2 CHAR(10) , K3 VARCHAR , K4 VARCHAR(1024) ) duplicate key (k1) distributed by hash(k1) buckets 1 properties('replication_num' = '1'); desc t2; ``` | Field | Type | Null | Key | Default | Extra | | -- |--|--| -| -| -| | k1 | CHAR(1) | Yes | true | NULL | | | K2 | CHAR(10) | Yes | false | NULL | NONE | | K3 | VARCHAR(65533) | Yes | false | NULL | NONE | | K4 | VARCHAR(1024) | Yes | false | NULL | NONE |
morningman
added a commit
to morningman/doris
that referenced
this pull request
Aug 10, 2023
This is only for branch-2.0 related to apache#21754 and apache#21302
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
modify archer default length 1 to varchar.max.length , when create table.
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...