Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[enhancement](merge-on-write) Add more log info when delete bitmap correctness check failed #22984

Merged
merged 8 commits into from
Aug 16, 2023
Merged

[enhancement](merge-on-write) Add more log info when delete bitmap correctness check failed #22984

merged 8 commits into from
Aug 16, 2023

Conversation

bobhan1
Copy link
Contributor

@bobhan1 bobhan1 commented Aug 15, 2023 •
edited
Loading

Proposed changes

when the delete bitmap correectness check failed, it will print logs like below indicating the rowsets that should have been considered and the missing rowsets' ids.

W0816 15:30:04.328012 2939820 tablet.cpp:3717] [txn_id:-1][tablet_id:10130][max_version: 12] check delete bitmap correctness failed!
W0816 15:30:04.328351 2939820 tablet.cpp:3765] {
    "requied_rowsets": [
        "[12-12] 2 DATA OVERLAPPING 020000000000003ac949b9452c99e0ea6388ebcb762536b1 131.37 KB",
        "[11-11] 2 DATA OVERLAPPING 0200000000000034c949b9452c99e0ea6388ebcb762536b1 131.36 KB",
        "[10-10] 2 DATA OVERLAPPING 0200000000000038c949b9452c99e0ea6388ebcb762536b1 136.82 KB",
        "[9-9] 2 DATA OVERLAPPING 0200000000000035c949b9452c99e0ea6388ebcb762536b1 136.82 KB",
        "[8-8] 2 DATA OVERLAPPING 0200000000000029c949b9452c99e0ea6388ebcb762536b1 131.37 KB",
        "[7-7] 2 DATA OVERLAPPING 0200000000000020c949b9452c99e0ea6388ebcb762536b1 131.37 KB",
        "[6-6] 2 DATA OVERLAPPING 0200000000000028c949b9452c99e0ea6388ebcb762536b1 136.82 KB",
        "[5-5] 2 DATA OVERLAPPING 0200000000000025c949b9452c99e0ea6388ebcb762536b1 136.82 KB",
        "[4-4] 1 DATA NONOVERLAPPING 0200000000000021c949b9452c99e0ea6388ebcb762536b1 136.82 KB",
        "[3-3] 1 DATA NONOVERLAPPING 020000000000001bc949b9452c99e0ea6388ebcb762536b1 131.37 KB",
        "[2-2] 1 DATA NONOVERLAPPING 0200000000000013c949b9452c99e0ea6388ebcb762536b1 181.04 KB"
    ],
    "missing_rowsets": [
        "0200000000000021c949b9452c99e0ea6388ebcb762536b1",
        "0200000000000020c949b9452c99e0ea6388ebcb762536b1",
        "0200000000000034c949b9452c99e0ea6388ebcb762536b1",
        "0200000000000013c949b9452c99e0ea6388ebcb762536b1",
        "020000000000001bc949b9452c99e0ea6388ebcb762536b1",
        "0200000000000025c949b9452c99e0ea6388ebcb762536b1",
        "0200000000000038c949b9452c99e0ea6388ebcb762536b1",
        "0200000000000028c949b9452c99e0ea6388ebcb762536b1",
        "020000000000003ac949b9452c99e0ea6388ebcb762536b1",
        "0200000000000029c949b9452c99e0ea6388ebcb762536b1",
        "0200000000000035c949b9452c99e0ea6388ebcb762536b1"
    ]
}
F0816 15:30:04.328388 2939820 tablet.cpp:3766] Check failed: false check delete bitmap correctness failed!

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@bobhan1
Copy link
Contributor Author

bobhan1 commented Aug 15, 2023

run buildall

@hello-stephen
Copy link
Contributor

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.26 seconds
stream load tsv: 542 seconds loaded 74807831229 Bytes, about 131 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.6 seconds inserted 10000000 Rows, about 337K ops/s
storage size: 17162028423 Bytes

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

zhannngchen
zhannngchen reviewed Aug 15, 2023
View reviewed changes
be/src/olap/tablet.cpp Outdated Show resolved Hide resolved
zhannngchen
zhannngchen reviewed Aug 15, 2023
View reviewed changes
be/src/olap/tablet.cpp Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

zhannngchen
zhannngchen reviewed Aug 15, 2023
View reviewed changes
be/src/olap/tablet.h Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@bobhan1
Copy link
Contributor Author

bobhan1 commented Aug 15, 2023

run buildall

zhannngchen
zhannngchen reviewed Aug 15, 2023
View reviewed changes
be/src/olap/tablet.cpp Outdated Show resolved Hide resolved
zhannngchen
zhannngchen reviewed Aug 15, 2023
View reviewed changes
be/src/olap/tablet.cpp Outdated Show resolved Hide resolved
@zhannngchen
Copy link
Contributor

add example logs to the description of this PR

@hello-stephen
Copy link
Contributor

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 44.69 seconds
stream load tsv: 539 seconds loaded 74807831229 Bytes, about 132 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.1 seconds inserted 10000000 Rows, about 343K ops/s
storage size: 17162345189 Bytes

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@bobhan1
Copy link
Contributor Author

bobhan1 commented Aug 16, 2023

run buildall

zhannngchen
zhannngchen previously approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@zhannngchen zhannngchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 16, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Aug 16, 2023
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@bobhan1
Copy link
Contributor Author

bobhan1 commented Aug 16, 2023

run buildall

@hello-stephen
Copy link
Contributor

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 47.12 seconds
stream load tsv: 542 seconds loaded 74807831229 Bytes, about 131 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.4 seconds inserted 10000000 Rows, about 340K ops/s
storage size: 17162313169 Bytes

zhannngchen
zhannngchen approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@zhannngchen zhannngchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 16, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

dataroaring
dataroaring approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit b815cf3 into apache:master Aug 16, 2023
26 of 30 checks passed
xiaokang pushed a commit that referenced this pull request Aug 17, 2023
@bobhan1 @xiaokang
[enhancement](merge-on-write) Add more log info when delete bitmap co…
1a71112 
…rrectness check failed (#22984)
airborne12 pushed a commit to airborne12/apache-doris that referenced this pull request Aug 21, 2023
@bobhan1 @airborne12
[enhancement](merge-on-write) Add more log info when delete bitmap co…
e221ef2 
…rrectness check failed (apache#22984)
@xiaokang xiaokang mentioned this pull request Aug 30, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhannngchen zhannngchen zhannngchen approved these changes

@Yukang-Lian Yukang-Lian Yukang-Lian approved these changes

@dataroaring dataroaring dataroaring approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.1-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@bobhan1 @hello-stephen @zhannngchen @Yukang-Lian @dataroaring @xiaokang