Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](catalog) fix hive partition prune bug on nereids #23026

Merged
merged 2 commits into from Aug 18, 2023
Merged

[fix](catalog) fix hive partition prune bug on nereids #23026

merged 2 commits into from Aug 18, 2023

Conversation

morningman
Copy link
Contributor

@morningman morningman commented Aug 15, 2023 •
edited

Proposed changes

Nereids uses different partition pruner to prune the partition.
The new partition pruner support predicate like cast(day1 as date) > cast("2023-08-16" as date)

This PR mainly changes:

  1. Use new partition pruner for hive tables
  2. Fix some error when query count(*) in hive table.
  3. change hive partition column with string type to varchar(65533), to avoid some unexpected behavior in partition pruning.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@morningman morningman added dev/2.0.1 dev/merged-1.0.0-deprecated PR has been merged into dev-1.0.0 p1_query_exception and removed dev/merged-1.0.0-deprecated PR has been merged into dev-1.0.0 labels Aug 15, 2023
@morningman morningman force-pushed the new_hive_partition_prune branch 2 times, most recently from 138a082 to f51ab76 Compare August 15, 2023 16:36
@morningman
Copy link
Contributor Author

run buildall

@hello-stephen
Copy link
Contributor

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 48.87 seconds
stream load tsv: 542 seconds loaded 74807831229 Bytes, about 131 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 99.5 seconds inserted 10000000 Rows, about 100K ops/s
storage size: 17162105418 Bytes

morningman added a commit to morningman/doris that referenced this pull request Aug 16, 2023
@morningman
[fix](catalog) fix hive partition prune bug on nereids apache#23026
6c80f20
@morningman
Copy link
Contributor Author

run buildall

@morningman
Copy link
Contributor Author

run buildall

1 similar comment
@morningman
Copy link
Contributor Author

run buildall

@morningman
Copy link
Contributor Author

run buildall

@hello-stephen
Copy link
Contributor

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 47.31 seconds
stream load tsv: 539 seconds loaded 74807831229 Bytes, about 132 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.3 seconds inserted 10000000 Rows, about 341K ops/s
storage size: 17162061651 Bytes

@AshinGau
Copy link
Member

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 18, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

xiaokang
xiaokang approved these changes Aug 18, 2023
View reviewed changes
Copy link
Contributor

@xiaokang xiaokang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xiaokang xiaokang merged commit 7c4870c into apache:master Aug 18, 2023
24 of 26 checks passed
xiaokang pushed a commit that referenced this pull request Aug 18, 2023
@morningman @xiaokang
[fix](catalog) fix hive partition prune bug on nereids (#23026)
9c1dcd9
airborne12 pushed a commit to airborne12/apache-doris that referenced this pull request Aug 21, 2023
@morningman @airborne12
[fix](catalog) fix hive partition prune bug on nereids (apache#23026)
5d9532e
@xiaokang xiaokang mentioned this pull request Aug 30, 2023
Open
@morningman morningman mentioned this pull request Mar 4, 2024
Merged
Jibing-Li pushed a commit to Jibing-Li/incubator-doris that referenced this pull request Mar 5, 2024
@morningman
[fix](hive) support partition prune for _HIVE_DEFAULT_PARTITION_ (apa…
2bbbdae 
…che#31736)

This PR apache#23026 support the partition prune for hive table with `_HIVE_DEFAULT_PARTITION`,
but it will always select partition with `_HIVE_DEFAULT_PARTITION`.

This PR apache#31613 support null partition for olap table's list partition, so we can treat `_HIVE_DEFAULT_PARTITION`
as null partition of hive table.

So this PR change the partition prune logic
yiguolei pushed a commit that referenced this pull request Mar 6, 2024
@morningman @Doris-Extras
[fix](hive) support partition prune for _HIVE_DEFAULT_PARTITION_ (#31736
ad3308c 
)

This PR #23026 support the partition prune for hive table with `_HIVE_DEFAULT_PARTITION`,
but it will always select partition with `_HIVE_DEFAULT_PARTITION`.

This PR #31613 support null partition for olap table's list partition, so we can treat `_HIVE_DEFAULT_PARTITION`
as null partition of hive table.

So this PR change the partition prune logic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaokang xiaokang xiaokang approved these changes

@AshinGau AshinGau AshinGau approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.1-merged p1_query_exception reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@morningman @hello-stephen @AshinGau @xiaokang