[fix](multi-catalog)fix compatibility issue for s3 endpoint when use incompatible client #23175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
run buildall |
1 similar comment
|
run buildall |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
|
run fe ut |
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
approved
|
PR approved by anyone and no changes requested. |
xiaokang
pushed a commit
that referenced
this pull request
Aug 18, 2023
airborne12
pushed a commit
to airborne12/apache-doris
that referenced
this pull request
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
there are some incompatible issues when use s3 endpoint but use oss,obs,cos location, fix them.
fix #22784
When s3 endpoint in catalog properties or load properties:
"s3.endpoint=cos.mycloud.com"
we can se its value is to access cos.
And then, when the query location is "s3://bucket/key" , we should use s3 client, and fit it with the s3 properties.
For another, when the query location is "cosn://bucket/key" , we should use cos client, and fit it with the cos properties.
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...