Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[enhancement](thirdparty) upgrade thirdparty libs - again #23414

Merged
merged 5 commits into from Aug 26, 2023
Merged

[enhancement](thirdparty) upgrade thirdparty libs - again #23414

merged 5 commits into from Aug 26, 2023

Conversation

xinyiZzz
Copy link
Contributor

@xinyiZzz xinyiZzz commented Aug 24, 2023 •
edited

Proposed changes

submit again #23290 (not upgrade brpc, because bthread local has error)

protobuf 3.15.0 -> 21.11
glog 0.4.0 -> 0.6.0
lz4 1.9.3 -> 1.9.4
curl 7.79.0 -> 8.2.1
zstd 1.5.2 -> 1.5.5
arrow 7.0.0 -> 13.0.0
abseil 20220623.1 -> 2023012.3
orc 1.7.2 -> 1.9.0
jemalloc for arrow 5.2.1 -> 5.3.0
xsimd 7.0.0 -> 13.0.0
opentelemetry-proto 0.19.0 -> 1.0.0
opentelemetry 1.8.3 -> 1.10.0

new:
c-ares -> 1.19.1
grpc -> 1.54.3

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@xinyiZzz
Copy link
Contributor Author

run buildall

1 similar comment
@xinyiZzz
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

yiguolei
yiguolei previously approved these changes Aug 24, 2023
View reviewed changes
Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 24, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@xinyiZzz xinyiZzz changed the title [enhancement](thirdparty) Roll back brpc to 1.4.0 [enhancement](thirdparty) upgrade thirdparty libs - again Aug 24, 2023
@xinyiZzz xinyiZzz force-pushed the 20230816_arrow_flight_be2_push_thridparty_rollback branch from fb3e4aa to 1996844 Compare August 24, 2023 13:06
@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Aug 24, 2023
@xinyiZzz
Copy link
Contributor Author

run buildall

@hello-stephen
Copy link
Contributor

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 47.56 seconds
stream load tsv: 537 seconds loaded 74807831229 Bytes, about 132 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.4 seconds inserted 10000000 Rows, about 340K ops/s
storage size: 17162022442 Bytes

@xinyiZzz xinyiZzz force-pushed the 20230816_arrow_flight_be2_push_thridparty_rollback branch from 1996844 to 02bfaa0 Compare August 24, 2023 16:27
@xinyiZzz
Copy link
Contributor Author

run buildall

@xinyiZzz xinyiZzz force-pushed the 20230816_arrow_flight_be2_push_thridparty_rollback branch from 02bfaa0 to 2fd1496 Compare August 26, 2023 09:49
@xinyiZzz
Copy link
Contributor Author

run buildall

@xinyiZzz xinyiZzz mentioned this pull request Aug 26, 2023
Closed
@xinyiZzz xinyiZzz force-pushed the 20230816_arrow_flight_be2_push_thridparty_rollback branch from 2fd1496 to e8b5a3f Compare August 26, 2023 09:57
@xinyiZzz
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@hello-stephen
Copy link
Contributor

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.08 seconds
stream load tsv: 543 seconds loaded 74807831229 Bytes, about 131 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 30 seconds loaded 861443392 Bytes, about 27 MB/s
insert into select: 29.8 seconds inserted 10000000 Rows, about 335K ops/s
storage size: 17161967619 Bytes

@hello-stephen
Copy link
Contributor

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 48.49 seconds
stream load tsv: 540 seconds loaded 74807831229 Bytes, about 132 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.6 seconds inserted 10000000 Rows, about 337K ops/s
storage size: 17162161549 Bytes

adonis0147
adonis0147 approved these changes Aug 26, 2023
View reviewed changes
Copy link
Contributor

@adonis0147 adonis0147 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 26, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

yiguolei
yiguolei approved these changes Aug 26, 2023
View reviewed changes
Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xinyiZzz xinyiZzz merged commit ba351af into apache:master Aug 26, 2023
24 of 26 checks passed
tudouzhao pushed a commit to tudouzhao/doris that referenced this pull request Aug 26, 2023
@caiconghui
[fix](metric) fix issue that the counter of rejected transactions doe…
1d1f866 
…s not cover some failed situations for load (apache#23363)

Co-authored-by: caiconghui1 <caiconghui1@jd.com>

[enhancement](thirdparty) upgrade thirdparty libs - again (apache#23414)

submit again apache#23290 (not upgrade brpc, because bthread local has error)

protobuf 3.15.0 -> 21.11
glog 0.4.0 -> 0.6.0
lz4 1.9.3 -> 1.9.4
curl 7.79.0 -> 8.2.1
zstd 1.5.2 -> 1.5.5
arrow 7.0.0 -> 13.0.0
abseil 20220623.1 -> 2023012.3
orc 1.7.2 -> 1.9.0
jemalloc for arrow 5.2.1 -> 5.3.0
xsimd 7.0.0 -> 13.0.0
opentelemetry-proto 0.19.0 -> 1.0.0
opentelemetry 1.8.3 -> 1.10.0

new:
c-ares -> 1.19.1
grpc -> 1.54.3
@adonis0147 adonis0147 mentioned this pull request Aug 27, 2023
Merged
xinyiZzz pushed a commit that referenced this pull request Aug 27, 2023
@adonis0147
[chore](build) Fix compilation errors for BE UT (#23535)
e0bf621 
Issue Number: close #23536

This issue was introduced by #23414 .
@RYH61 RYH61 mentioned this pull request Sep 14, 2023
Merged
@xinyiZzz xinyiZzz mentioned this pull request Oct 17, 2023
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adonis0147 adonis0147 adonis0147 approved these changes

@yiguolei yiguolei yiguolei approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@xinyiZzz @hello-stephen @adonis0147 @yiguolei