Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](Nereids) make TVF's distribution spec always be RANDOM #24020

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

morrySnow
Copy link
Contributor

@morrySnow morrySnow commented Sep 7, 2023

Proposed changes

Issue Number: close #xxx

Nereids make TVF number as Gather distribution if backend num = 1.
But coordinator could not process gather fragment with scan node.
In the long run, we need to get coordinators to support this scenario.
But it is need a lot of refactor. So, we just forbid Gather
distribution for ScanNode now.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@morrySnow
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 50.02 seconds
stream load tsv: 540 seconds loaded 74807831229 Bytes, about 132 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.0 seconds inserted 10000000 Rows, about 344K ops/s
storage size: 17161960480 Bytes

@morrySnow
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 49.64 seconds
stream load tsv: 530 seconds loaded 74807831229 Bytes, about 134 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.2 seconds inserted 10000000 Rows, about 342K ops/s
storage size: 17161953604 Bytes

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

PR approved by anyone and no changes requested.

@morrySnow
Copy link
Contributor Author

run feut


// when we set numbers to gather, coordinator could not process and set none scan range in thrift
// so we add this test case to ensure this sql do not core dump
sql """
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the purpose of this sql?

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 7, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

PR approved by at least one committer and no changes requested.

@morrySnow morrySnow merged commit 2633754 into apache:master Sep 7, 2023
25 of 27 checks passed
xiaokang pushed a commit that referenced this pull request Sep 8, 2023
Nereids make TVF number as Gather distribution if backend num = 1.
But coordinator could not process gather fragment with scan node.
In the long run, we need to get coordinators to support this scenario.
But it is need a lot of refactor. So, we just forbid Gather distribution
for ScanNode now.
@xiaokang xiaokang mentioned this pull request Sep 28, 2023
@morrySnow morrySnow deleted the two_number_in_one branch October 10, 2023 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.2-merged p0_c reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants