Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[optimize](match) optimize unnecessary conversions #24389

Merged
merged 1 commit into from Sep 21, 2023

Conversation

zzzxl1993
Copy link
Contributor

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@zzzxl1993
Copy link
Contributor Author

run buildall

Copy link
Contributor

@airborne12 airborne12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.96% (7974/21575)
Line Coverage: 28.92% (63902/220995)
Region Coverage: 27.84% (33165/119107)
Branch Coverage: 24.40% (17011/69706)
Coverage Report: http://coverage.selectdb-in.cc/coverage/4d69606a9ce965552ce976fdd9b865931db5dddf_4d69606a9ce965552ce976fdd9b865931db5dddf/report/index.html

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 48.58 seconds
stream load tsv: 593 seconds loaded 74807831229 Bytes, about 120 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 28.8 seconds inserted 10000000 Rows, about 347K ops/s
storage size: 17162341035 Bytes

xiaokang
xiaokang previously approved these changes Sep 14, 2023
Copy link
Contributor

@xiaokang xiaokang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 14, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@zzzxl1993
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 51.25 seconds
stream load tsv: 601 seconds loaded 74807831229 Bytes, about 118 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.7 seconds inserted 10000000 Rows, about 336K ops/s
storage size: 17162273315 Bytes

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.82% (7979/21669)
Line Coverage: 28.85% (64022/221924)
Region Coverage: 27.74% (33228/119778)
Branch Coverage: 24.36% (17032/69908)
Coverage Report: http://coverage.selectdb-in.cc/coverage/1309a38e0e380b3b6422e230eaddf8d2818f647f_1309a38e0e380b3b6422e230eaddf8d2818f647f/report/index.html

@zzzxl1993
Copy link
Contributor Author

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Sep 20, 2023
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.42% (8021/22024)
Line Coverage: 28.71% (64376/224247)
Region Coverage: 27.66% (33418/120819)
Branch Coverage: 24.30% (17099/70358)
Coverage Report: http://coverage.selectdb-in.cc/coverage/d6b48ddec0174d636cb4b35b2de9f7bbfcfeb111_d6b48ddec0174d636cb4b35b2de9f7bbfcfeb111/report/index.html

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.89 seconds
stream load tsv: 614 seconds loaded 74807831229 Bytes, about 116 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size: 17162159980 Bytes

Copy link
Contributor

@qidaye qidaye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 21, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@xiaokang xiaokang merged commit 5a463fe into apache:master Sep 21, 2023
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.2-merged p0_b reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants