Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve](explode) improve explode func with array nested complex type #24455

Merged

Conversation

amorynan
Copy link
Contributor

Proposed changes

Issue Number: close #xxx
make explode with array nested complex type

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@amorynan
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

@BiteTheDDDDt BiteTheDDDDt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 15, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.83% (7979/21664)
Line Coverage: 28.85% (63971/221726)
Region Coverage: 27.78% (33196/119484)
Branch Coverage: 24.37% (17032/69880)
Coverage Report: http://coverage.selectdb-in.cc/coverage/7d541c373e412ff653b6b0315cf76cef1f28c461_7d541c373e412ff653b6b0315cf76cef1f28c461/report/index.html

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 47.03 seconds
stream load tsv: 593 seconds loaded 74807831229 Bytes, about 120 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.8 seconds inserted 10000000 Rows, about 347K ops/s
storage size: 17162417928 Bytes

@amorynan
Copy link
Contributor Author

run beut

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.84% (7978/21654)
Line Coverage: 28.86% (64010/221777)
Region Coverage: 27.78% (33203/119504)
Branch Coverage: 24.38% (17039/69896)
Coverage Report: http://coverage.selectdb-in.cc/coverage/7d541c373e412ff653b6b0315cf76cef1f28c461_7d541c373e412ff653b6b0315cf76cef1f28c461/report/index.html

@xiaokang xiaokang added dev/2.0.3 usercase Important user case type label labels Sep 16, 2023
@amorynan
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.83% (7981/21669)
Line Coverage: 28.86% (64050/221928)
Region Coverage: 27.75% (33239/119776)
Branch Coverage: 24.37% (17034/69906)
Coverage Report: http://coverage.selectdb-in.cc/coverage/2b8dcb9b1b21933755867791d333b5b1733f63b4_2b8dcb9b1b21933755867791d333b5b1733f63b4/report/index.html

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.98 seconds
stream load tsv: 617 seconds loaded 74807831229 Bytes, about 115 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 28.8 seconds inserted 10000000 Rows, about 347K ops/s
storage size: 17162433342 Bytes

@amorynan
Copy link
Contributor Author

run feut

@BiteTheDDDDt BiteTheDDDDt merged commit 96f1971 into apache:master Sep 18, 2023
22 checks passed
xiaokang pushed a commit that referenced this pull request Sep 18, 2023
@xiaokang xiaokang mentioned this pull request Sep 30, 2023
@xiaokang xiaokang mentioned this pull request Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.2-merged reviewed usercase Important user case type label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants