Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](multicatalog)fix jdbc catalog current_timestamp default #25016

Merged
merged 4 commits into from Oct 7, 2023

Conversation

vinlee19
Copy link
Contributor

Proposed changes

image

This problem is caused when you read table data from Mariadb where the datatime type default value is set to current_timestamp().

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@vinlee19
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.63 seconds
stream load tsv: 564 seconds loaded 74807831229 Bytes, about 126 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.4 seconds inserted 10000000 Rows, about 340K ops/s
storage size: 17162257506 Bytes

@wm1581066 wm1581066 added dev/2.0.3 usercase Important user case type label labels Sep 29, 2023
@zy-kkk zy-kkk self-assigned this Oct 3, 2023
Copy link
Contributor Author

@vinlee19 vinlee19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

run buildall

@vinlee19 vinlee19 requested a review from zy-kkk October 5, 2023 02:10
@zy-kkk
Copy link
Member

zy-kkk commented Oct 6, 2023

run buildall

1 similar comment
@shuke987
Copy link
Collaborator

shuke987 commented Oct 6, 2023

run buildall

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.92 seconds
stream load tsv: 581 seconds loaded 74807831229 Bytes, about 122 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 33 seconds loaded 861443392 Bytes, about 24 MB/s
insert into select: 29.1 seconds inserted 10000000 Rows, about 343K ops/s
storage size: 17162328708 Bytes

Copy link
Member

@zy-kkk zy-kkk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@LemonLiTree LemonLiTree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 7, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2023

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2023

PR approved by anyone and no changes requested.

@zy-kkk zy-kkk merged commit 47694c5 into apache:master Oct 7, 2023
24 of 27 checks passed
vinlee19 added a commit to vinlee19/doris that referenced this pull request Oct 7, 2023
…e#25016)

This problem is caused when you read table data from Mariadb where the datatime type default value is set to current_timestamp().
xiaokang pushed a commit that referenced this pull request Oct 7, 2023
This problem is caused when you read table data from Mariadb where the datatime type default value is set to current_timestamp().
@xiaokang xiaokang mentioned this pull request Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.3-merged reviewed usercase Important user case type label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants