Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](Nereids) non-slot filter should not be push through aggregate #25525

Merged
merged 1 commit into from Oct 17, 2023
Merged

[fix](Nereids) non-slot filter should not be push through aggregate #25525

merged 1 commit into from Oct 17, 2023

Conversation

morrySnow
Copy link
Contributor

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@morrySnow
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.38 seconds
stream load tsv: 558 seconds loaded 74807831229 Bytes, about 127 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.0 seconds inserted 10000000 Rows, about 344K ops/s
storage size: 17162016505 Bytes

@morrySnow morrySnow added the p0_w label Oct 17, 2023
englefly
englefly reviewed Oct 17, 2023
View reviewed changes
regression-test/suites/nereids_rules_p0/filter_push_down/filter_push_through_aggregate.groovy
sql "set disable_nereids_rules='REWRITE_FILTER_EXPRESSION'"

// 'a' = 'b' should not be push down aggregate.
qt_do_not_push_no_slot_filter """
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this case can not verify that a='b' is pushed down or not.
we need to insert some tuple and check the query result. before this pr, sum column is NULL

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a = 'b' will generate 'a' = 'b'

@englefly
Copy link
Contributor

join suffers the same issue.

@morrySnow
Copy link
Contributor Author

join suffers the same issue.

fix in another PR

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 17, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@morrySnow morrySnow merged commit 9d6b2dc into apache:master Oct 17, 2023
31 of 34 checks passed
xiaokang pushed a commit that referenced this pull request Oct 17, 2023
@morrySnow @xiaokang
[fix](Nereids) non-slot filter should not be push through aggregate (#…
1016ed2 
…25525)
dutyu pushed a commit to dutyu/doris that referenced this pull request Oct 28, 2023
@morrySnow
[fix](Nereids) non-slot filter should not be push through aggregate (a…
ee4c29c 
…pache#25525)
@morrySnow morrySnow deleted the push_slot_to_agg branch October 30, 2023 03:15
wsjz pushed a commit to wsjz/incubator-doris that referenced this pull request Nov 19, 2023
@morrySnow @wsjz
[fix](Nereids) non-slot filter should not be push through aggregate (a…
16159b1 
…pache#25525)
@xiaokang xiaokang mentioned this pull request Dec 4, 2023
Open
XuJianxu pushed a commit to XuJianxu/doris that referenced this pull request Dec 14, 2023
@morrySnow
[fix](Nereids) non-slot filter should not be push through aggregate (a…
0c0c3fa 
…pache#25525)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@englefly englefly englefly approved these changes

@XieJiann XieJiann XieJiann approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.3-merged p0_w reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@morrySnow @doris-robot @englefly @XieJiann @xiaokang