Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](backup) missing use_path_style properties for minio #25803

Merged
merged 2 commits into from Oct 25, 2023
Merged

[fix](backup) missing use_path_style properties for minio #25803

merged 2 commits into from Oct 25, 2023

Conversation

morningman
Copy link
Contributor

@morningman morningman commented Oct 23, 2023 •
edited

Proposed changes

Follow #25496.
In #25496, I fixed the issue that the aws s3 properties are invalid when passing from FE to BE.
But it missed the use_path_style property, which is useful for minio access.
This PR fix it.

The test cases for minio will be added after this PR #25424 merged

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@morningman morningman added usercase Important user case type label dev/2.0.3 labels Oct 23, 2023
@morningman
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.02% (8296/22410)
Line Coverage: 29.17% (66631/228412)
Region Coverage: 27.76% (34607/124680)
Branch Coverage: 24.42% (17581/72006)
Coverage Report: http://coverage.selectdb-in.cc/coverage/c413613a2d43aaa23d8c490811f18f2d5eff3354_c413613a2d43aaa23d8c490811f18f2d5eff3354/report/index.html

@zhangguoqiang666
Copy link
Contributor

run external

@morningman morningman marked this pull request as ready for review October 24, 2023 10:28
@morningman morningman mentioned this pull request Oct 24, 2023
Merged
xiaokang pushed a commit that referenced this pull request Oct 24, 2023
@morningman
[fix](backup) missing use_path_style properties for minio #25803 (#25850
a3874c2 
)
@morningman
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.69 seconds
stream load tsv: 553 seconds loaded 74807831229 Bytes, about 129 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.0 seconds inserted 10000000 Rows, about 344K ops/s
storage size: 17162132306 Bytes

@morningman
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.3 seconds
stream load tsv: 555 seconds loaded 74807831229 Bytes, about 128 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size: 17161972952 Bytes

wsjz
wsjz approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@wsjz wsjz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 25, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@AshinGau AshinGau merged commit 0dcbc5e into apache:master Oct 25, 2023
24 of 26 checks passed
dutyu pushed a commit to dutyu/doris that referenced this pull request Oct 28, 2023
@morningman
[fix](backup) missing use_path_style properties for minio (apache#25803)
4addf4c 
Follow apache#25496.
In apache#25496, I fixed the issue that the aws s3 properties are invalid when passing from FE to BE.
But it missed the `use_path_style` property, which is useful for minio access.
This PR fix it.
wsjz pushed a commit to wsjz/incubator-doris that referenced this pull request Nov 19, 2023
@morningman @wsjz
[fix](backup) missing use_path_style properties for minio (apache#25803)
c787cac 
Follow apache#25496.
In apache#25496, I fixed the issue that the aws s3 properties are invalid when passing from FE to BE.
But it missed the `use_path_style` property, which is useful for minio access.
This PR fix it.
gnehil pushed a commit to gnehil/doris that referenced this pull request Dec 4, 2023
@morningman
[fix](backup) missing use_path_style properties for minio apache#25803 (
45b5607 
apache#25850)
@xiaokang xiaokang mentioned this pull request Dec 4, 2023
Open
XuJianxu pushed a commit to XuJianxu/doris that referenced this pull request Dec 14, 2023
@morningman
[fix](backup) missing use_path_style properties for minio (apache#25803)
744c8dd 
Follow apache#25496.
In apache#25496, I fixed the issue that the aws s3 properties are invalid when passing from FE to BE.
But it missed the `use_path_style` property, which is useful for minio access.
This PR fix it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wsjz wsjz wsjz approved these changes

@AshinGau AshinGau AshinGau approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.3-merged reviewed usercase Important user case type label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@morningman @doris-robot @zhangguoqiang666 @wsjz @AshinGau @xiaokang