Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug](materialized-view) add limit for group by with float/double on create mv #25823

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

BiteTheDDDDt
Copy link
Contributor

Proposed changes

doris do not support float/double key type on storage engine.

*** Query id: 0-0 ***
*** tablet id: 0 ***
*** Aborted at 1698114021 (unix time) try "date -d @1698114021" if you are using GNU date ***
*** Current BE git commitID: 29b4448635 ***
*** SIGSEGV address not mapped to object (@0x0) received by PID 737595 (TID 740061 OR 0x7f0f225ff700) from PID 0; stack trace: ***
 0# doris::signal::(anonymous namespace)::FailureSignalHandler(int, siginfo_t*, void*) at /mnt/disk2/liyuanyuan/enterprise-core/2.2.0.2/enterprise-core/be/src/common/signal_handler.h:417
 1# os::Linux::chained_handler(int, siginfo*, void*) in /mnt/disk2/liyuanyuan/ldb/jdk8/jre/lib/amd64/server/libjvm.so
 2# JVM_handle_linux_signal in /mnt/disk2/liyuanyuan/ldb/jdk8/jre/lib/amd64/server/libjvm.so
 3# signalHandler(int, siginfo*, void*) in /mnt/disk2/liyuanyuan/ldb/jdk8/jre/lib/amd64/server/libjvm.so
 4# 0x00007F115F086B50 in /lib64/libc.so.6
 5# doris::segment_v2::SegmentWriter::_full_encode_keys[abi:cxx11](std::vector<doris::vectorized::IOlapColumnDataAccessor*, std::allocator<doris::vectorized::IOlapColumnDataAccessor*> > const&, unsigned long, bool) at /mnt/disk2/liyuanyuan/enterprise-core/2.2.0.2/enterprise-core/be/src/olap/rowset/segment_v2/segment_writer.cpp:743
 6# doris::segment_v2::SegmentWriter::append_block(doris::vectorized::Block const*, unsigned long, unsigned long) at /mnt/disk2/liyuanyuan/enterprise-core/2.2.0.2/enterprise-core/be/src/olap/rowset/segment_v2/segment_writer.cpp:696
 7# doris::BetaRowsetWriter::_do_add_block(doris::vectorized::Block const*, std::unique_ptr<doris::segment_v2::SegmentWriter, std::default_delete<doris::segment_v2::SegmentWriter> >*, unsigned long, unsigned long) at /mnt/disk2/liyuanyuan/enterprise-core/2.2.0.2/enterprise-core/be/src/olap/rowset/beta_rowset_writer.cpp:392
 8# doris::BetaRowsetWriter::_add_block(doris::vectorized::Block const*, std::unique_ptr<doris::segment_v2::SegmentWriter, std::default_delete<doris::segment_v2::SegmentWriter> >*, doris::FlushContext const*) at /mnt/disk2/liyuanyuan/enterprise-core/2.2.0.2/enterprise-core/be/src/olap/rowset/beta_rowset_writer.cpp:408
 9# doris::BetaRowsetWriter::flush_single_memtable(doris::vectorized::Block const*, long*, doris::FlushContext const*) at /mnt/disk2/liyuanyuan/enterprise-core/2.2.0.2/enterprise-core/be/src/olap/rowset/beta_rowset_writer.cpp:472
10# doris::MemTable::_do_flush() at /mnt/disk2/liyuanyuan/enterprise-core/2.2.0.2/enterprise-core/be/src/olap/memtable.cpp:540
11# doris::MemTable::flush() at /mnt/disk2/liyuanyuan/enterprise-core/2.2.0.2/enterprise-core/be/src/olap/memtable.cpp:503
12# doris::FlushToken::_flush_memtable(doris::MemTable*, long) at /mnt/disk2/liyuanyuan/enterprise-core/2.2.0.2/enterprise-core/be/src/olap/memtable_flush_executor.cpp:99
13# doris::MemtableFlushTask::run() at /mnt/disk2/liyuanyuan/enterprise-core/2.2.0.2/enterprise-core/be/src/olap/memtable_flush_executor.cpp:47
14# doris::ThreadPool::dispatch_thread() in /mnt/disk2/liyuanyuan/enterprise-core/2.2.0.2/selectdb-doris-2.0.2-ikas/be/lib/doris_be
15# doris::Thread::supervise_thread(void*) at /mnt/disk2/liyuanyuan/enterprise-core/2.2.0.2/enterprise-core/be/src/util/thread.cpp:470
16# start_thread in /lib64/libpthread.so.0
17# __clone in /lib64/libc.so.6 

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@BiteTheDDDDt
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.48 seconds
stream load tsv: 551 seconds loaded 74807831229 Bytes, about 129 MB/s
stream load json: 23 seconds loaded 2358488459 Bytes, about 97 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.8 seconds inserted 10000000 Rows, about 347K ops/s
storage size: 17161914623 Bytes

Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 24, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@BiteTheDDDDt BiteTheDDDDt merged commit 091cb0c into apache:master Oct 24, 2023
24 of 27 checks passed
xiaokang pushed a commit that referenced this pull request Oct 24, 2023
…create mv (#25823)

doris do not support float/double key type on storage engine.
dutyu pushed a commit to dutyu/doris that referenced this pull request Oct 28, 2023
…create mv (apache#25823)

doris do not support float/double key type on storage engine.
wsjz pushed a commit to wsjz/incubator-doris that referenced this pull request Nov 19, 2023
…create mv (apache#25823)

doris do not support float/double key type on storage engine.
gnehil pushed a commit to gnehil/doris that referenced this pull request Dec 4, 2023
…create mv (apache#25823)

doris do not support float/double key type on storage engine.
@xiaokang xiaokang mentioned this pull request Dec 4, 2023
XuJianxu pushed a commit to XuJianxu/doris that referenced this pull request Dec 14, 2023
…create mv (apache#25823)

doris do not support float/double key type on storage engine.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.3-merged p0_c reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants