Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature-wip](arrow-flight)(step4) Support other DML and DDL statements, besides Select #25919

Merged
merged 2 commits into from
Nov 8, 2023
Merged

[feature-wip](arrow-flight)(step4) Support other DML and DDL statements, besides Select #25919

merged 2 commits into from
Nov 8, 2023

Conversation

xinyiZzz
Copy link
Contributor

Proposed changes

Design Documentation Linked to #25514

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@xinyiZzz xinyiZzz marked this pull request as draft October 25, 2023 14:26
@xinyiZzz xinyiZzz force-pushed the 20231016_support_session_veriable_flight branch 2 times, most recently from 74942f8 to 267c526 Compare October 30, 2023 08:52
github-actions[bot]
github-actions bot reviewed Nov 1, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

be/src/runtime/result_buffer_mgr.cpp Show resolved Hide resolved
@xinyiZzz xinyiZzz marked this pull request as ready for review November 2, 2023 01:29
@xinyiZzz
Copy link
Contributor Author

xinyiZzz commented Nov 2, 2023

run buildall

@xinyiZzz xinyiZzz force-pushed the 20231016_support_session_veriable_flight branch from d1fcb74 to 68e0cfa Compare November 2, 2023 09:28
@xinyiZzz
Copy link
Contributor Author

xinyiZzz commented Nov 2, 2023

run buildall

@xinyiZzz xinyiZzz force-pushed the 20231016_support_session_veriable_flight branch from 2d30cd9 to b4d9fda Compare November 2, 2023 13:05
@xinyiZzz
Copy link
Contributor Author

xinyiZzz commented Nov 2, 2023

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.28% (8452/22669)
Line Coverage: 29.68% (68431/230578)
Region Coverage: 28.33% (35407/124964)
Branch Coverage: 25.07% (18072/72074)
Coverage Report: http://coverage.selectdb-in.cc/coverage/b4d9fda98053ddc201ca0ff969b076a89ff31a4c_b4d9fda98053ddc201ca0ff969b076a89ff31a4c/report/index.html

@xinyiZzz
Copy link
Contributor Author

xinyiZzz commented Nov 3, 2023

run buildall

github-actions[bot]
github-actions bot reviewed Nov 3, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

be/src/runtime/result_buffer_mgr.h Outdated Show resolved Hide resolved
@xinyiZzz
Copy link
Contributor Author

xinyiZzz commented Nov 3, 2023

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.29% (8452/22666)
Line Coverage: 29.68% (68437/230621)
Region Coverage: 28.34% (35414/124974)
Branch Coverage: 25.07% (18073/72080)
Coverage Report: http://coverage.selectdb-in.cc/coverage/42702411f83cb7be6da384598ce7a84444b828ab_42702411f83cb7be6da384598ce7a84444b828ab/report/index.html

@xinyiZzz
Copy link
Contributor Author

xinyiZzz commented Nov 3, 2023

run buildall

github-actions[bot]
github-actions bot reviewed Nov 3, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

be/src/runtime/result_buffer_mgr.cpp Show resolved Hide resolved
@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.30% (8454/22666)
Line Coverage: 29.68% (68457/230625)
Region Coverage: 28.35% (35426/124979)
Branch Coverage: 25.08% (18077/72084)
Coverage Report: http://coverage.selectdb-in.cc/coverage/893e1a29643c577a061b8349f1bc041d16f936d6_893e1a29643c577a061b8349f1bc041d16f936d6/report/index.html

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.58 seconds
stream load tsv: 558 seconds loaded 74807831229 Bytes, about 127 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.0 seconds inserted 10000000 Rows, about 344K ops/s
storage size: 17162116387 Bytes

@xinyiZzz xinyiZzz force-pushed the 20231016_support_session_veriable_flight branch from 893e1a2 to f178572 Compare November 5, 2023 16:08
@xinyiZzz
Copy link
Contributor Author

xinyiZzz commented Nov 5, 2023

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.29% (8452/22667)
Line Coverage: 29.68% (68442/230636)
Region Coverage: 28.33% (35408/124980)
Branch Coverage: 25.07% (18075/72084)
Coverage Report: http://coverage.selectdb-in.cc/coverage/f178572d22f6371c78562d92d7f66c0115e9ae02_f178572d22f6371c78562d92d7f66c0115e9ae02/report/index.html

@xinyiZzz xinyiZzz force-pushed the 20231016_support_session_veriable_flight branch from f178572 to 5328810 Compare November 5, 2023 17:02
@xinyiZzz
Copy link
Contributor Author

xinyiZzz commented Nov 5, 2023

run buildall

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.16 seconds
stream load tsv: 574 seconds loaded 74807831229 Bytes, about 124 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 34 seconds loaded 861443392 Bytes, about 24 MB/s
insert into select: 28.8 seconds inserted 10000000 Rows, about 347K ops/s
storage size: 17162362181 Bytes

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.30% (8454/22667)
Line Coverage: 29.68% (68455/230636)
Region Coverage: 28.34% (35417/124980)
Branch Coverage: 25.08% (18079/72084)
Coverage Report: http://coverage.selectdb-in.cc/coverage/5328810b31d85ade7ca10939e31f6a3c4beaf4ff_5328810b31d85ade7ca10939e31f6a3c4beaf4ff/report/index.html

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.58 seconds
stream load tsv: 576 seconds loaded 74807831229 Bytes, about 123 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 33 seconds loaded 861443392 Bytes, about 24 MB/s
insert into select: 28.7 seconds inserted 10000000 Rows, about 348K ops/s
storage size: 17162621155 Bytes

yiguolei
yiguolei approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 7, 2023

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Nov 7, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 7, 2023

PR approved by anyone and no changes requested.

@xinyiZzz xinyiZzz merged commit 1544110 into apache:master Nov 8, 2023
25 of 27 checks passed
seawinde pushed a commit to seawinde/doris that referenced this pull request Nov 8, 2023
@xinyiZzz @seawinde
[feature-wip](arrow-flight)(step4) Support other DML and DDL statemen…
3794034 
…ts, besides `Select` (apache#25919)

Design Documentation Linked to apache#25514
seawinde pushed a commit to seawinde/doris that referenced this pull request Nov 13, 2023
@xinyiZzz @seawinde
[feature-wip](arrow-flight)(step4) Support other DML and DDL statemen…
41931f7 
…ts, besides `Select` (apache#25919)

Design Documentation Linked to apache#25514
wsjz pushed a commit to wsjz/incubator-doris that referenced this pull request Nov 19, 2023
@xinyiZzz @wsjz
[feature-wip](arrow-flight)(step4) Support other DML and DDL statemen…
7ead5f5 
…ts, besides `Select` (apache#25919)

Design Documentation Linked to apache#25514
@xinyiZzz xinyiZzz mentioned this pull request Dec 1, 2023
Open
1 task
XuJianxu pushed a commit to XuJianxu/doris that referenced this pull request Dec 14, 2023
@xinyiZzz
[feature-wip](arrow-flight)(step4) Support other DML and DDL statemen…
cd5b7a5 
…ts, besides `Select` (apache#25919)

Design Documentation Linked to apache#25514
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions left review comments

@yiguolei yiguolei yiguolei approved these changes

@zclllyybb zclllyybb zclllyybb approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@xinyiZzz @doris-robot @yiguolei @zclllyybb