Return NullLiteral in castTo method instead of throwing a exception #2799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xy720
changed the title
EmmyMiao87
reviewed
Jan 20, 2020
| parsedStmt.rewriteExprs(rewriter); | ||
|
|
||
| Expr result = parsedStmt.getSelectList().getItems().get(0).getExpr(); | ||
| Assert.assertEquals(Expr.IS_NULL_LITERAL.apply(result), true); |
There was a problem hiding this comment.
what the different between IS_NULL_LITERAL and result instance of NullLiteral
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#2399
#2396 (2.2)
We used to use Precondition to throw an exception when encounter a NullLiteral in castTo method. So if the child of CastExpr is NullLiteral, then this CastExpr will throw an exception when invoking the castTo method.
And this may make the user not get the desired result.
For example, we get an unexpected exception in query: (In sql mode
PIPES_AS_CONCAT_MODE)select (1 || 'a' > 0) + 1;which should return a result 'Null'.