Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improvement](decimal) use new way for decimal arithmetic precision promotion(#27787) #28034

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

jacktengg
Copy link
Contributor

Proposed changes

Pick from #27787

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions github-actions bot added area/nereids area/planner Issues or PRs related to the query planner kind/test labels Dec 5, 2023
Copy link
Contributor

github-actions bot commented Dec 5, 2023

clang-tidy review says "All clean, LGTM! 👍"

@jacktengg
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.83% (7987/21115)
Line Coverage: 29.54% (64852/219536)
Region Coverage: 29.00% (33358/115019)
Branch Coverage: 24.91% (17133/68772)
Coverage Report: http://coverage.selectdb-in.cc/coverage/cbd087d3be53dc26c8188e69f082eb0d9ce7f4db_cbd087d3be53dc26c8188e69f082eb0d9ce7f4db/report/index.html

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.71 seconds
stream load tsv: 585 seconds loaded 74807831229 Bytes, about 121 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.6 seconds inserted 10000000 Rows, about 337K ops/s
storage size: 17164180497 Bytes

@jacktengg
Copy link
Contributor Author

run buildall

Copy link
Contributor

github-actions bot commented Dec 6, 2023

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.82% (7985/21115)
Line Coverage: 29.53% (64838/219536)
Region Coverage: 28.99% (33348/115019)
Branch Coverage: 24.91% (17128/68772)
Coverage Report: http://coverage.selectdb-in.cc/coverage/1ef402b834015ef3553eb3dd720b4bd6c4ea9b29_1ef402b834015ef3553eb3dd720b4bd6c4ea9b29/report/index.html

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.22 seconds
stream load tsv: 590 seconds loaded 74807831229 Bytes, about 120 MB/s
stream load json: 22 seconds loaded 2358488459 Bytes, about 102 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.8 seconds inserted 10000000 Rows, about 335K ops/s
storage size: 17162466054 Bytes

@jacktengg
Copy link
Contributor Author

run p0

1 similar comment
@yiguolei
Copy link
Contributor

yiguolei commented Dec 7, 2023

run p0

Copy link
Contributor

github-actions bot commented Dec 7, 2023

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Dec 7, 2023
Copy link
Contributor

github-actions bot commented Dec 7, 2023

PR approved by anyone and no changes requested.

@yiguolei yiguolei merged commit 7ef9521 into apache:branch-2.0 Dec 8, 2023
22 of 26 checks passed
@xiaokang xiaokang mentioned this pull request Jan 14, 2024
@xiaokang xiaokang mentioned this pull request Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. area/nereids area/planner Issues or PRs related to the query planner kind/behavior-changed kind/test reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants