[Bug] Stop incorrectly of reportwork cause heap use after free #32205

wyxxxcat · 2024-03-13T15:43:15Z

Proposed changes

Issue Number: close #xxx

When a port conflict occurs, an incorrect exit is caused

Further comments

=================================================================
==1511173==ERROR: AddressSanitizer: heap-use-after-free on address 0x51000004e270 at pc 0x5641a1a823f9 bp 0x7f7381ab57b0 sp 0x7f7381ab57a8
READ of size 4 at 0x51000004e270 thread T1220 (REPORT_TASK-151)
    #0 0x5641a1a823f8 in doris::ReportWorker::ReportWorker(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>, doris::TMasterInfo const&, int, std::function<void ()>)::$_0::operator()() const /home/yixuan/doris/be/src/agent/task_worker_pool.cpp:587:45
    #1 0x5641a1a81fb4 in void std::__invoke_impl<void, doris::ReportWorker::ReportWorker(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>, doris::TMasterInfo const&, int, std::function<void ()>)::$_0&>(std::__invoke_other, doris::ReportWorker::ReportWorker(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>, doris::TMasterInfo const&, int, std::function<void ()>)::$_0&) /home/yixuan/ldb_tool/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/invoke.h:61:14
    #2 0x5641a1a81f54 in std::enable_if<is_invocable_r_v<void, doris::ReportWorker::ReportWorker(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>, doris::TMasterInfo const&, int, std::function<void ()>)::$_0&>, void>::type std::__invoke_r<void, doris::ReportWorker::ReportWorker(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>, doris::TMasterInfo const&, int, std::function<void ()>)::$_0&>(doris::ReportWorker::ReportWorker(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>, doris::TMasterInfo const&, int, std::function<void ()>)::$_0&) /home/yixuan/ldb_tool/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/invoke.h:111:2
    #3 0x5641a1a81d4c in std::_Function_handler<void (), doris::ReportWorker::ReportWorker(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>, doris::TMasterInfo const&, int, std::function<void ()>)::$_0>::_M_invoke(std::_Any_data const&) /home/yixuan/ldb_tool/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/std_function.h:290:9
    #4 0x56419f523ce2 in std::function<void ()>::operator()() const /home/yixuan/ldb_tool/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/std_function.h:591:9
    #5 0x5641a2d6495b in doris::Thread::supervise_thread(void*) /home/yixuan/doris/be/src/util/thread.cpp:498:5
    #6 0x56419f357e0a in asan_thread_start(void*) crtstuff.c
    #7 0x7f79c49cd608 in start_thread /build/glibc-SzIz7B/glibc-2.31/nptl/pthread_create.c:477:8
    #8 0x7f79c4c7a132 in __clone /build/glibc-SzIz7B/glibc-2.31/misc/../sysdeps/unix/sysv/linux/x86_64/clone.S:95

0x51000004e270 is located 48 bytes inside of 192-byte region [0x51000004e240,0x51000004e300)
freed by thread T0 here:
    #0 0x56419f39743d in operator delete(void*) (/home/yixuan/doris/output/be/lib/doris_be+0x2165943d) (BuildId: d7c9d2a3e104bf3f)
    #1 0x5641a3627301 in doris::TMasterInfo::~TMasterInfo() /home/yixuan/doris/gensrc/build/gen_cpp/HeartbeatService_types.cpp:133:38
    #2 0x5641a2234057 in doris::ExecEnv::destroy() /home/yixuan/doris/be/src/runtime/exec_env_init.cpp:637:5
    #3 0x5641a2211848 in doris::ExecEnv::~ExecEnv() /home/yixuan/doris/be/src/runtime/exec_env.cpp:44:5
    #4 0x7f79c4ba18a6 in __run_exit_handlers /build/glibc-SzIz7B/glibc-2.31/stdlib/exit.c:108:8

previously allocated by thread T0 here:
    #0 0x56419f396bdd in operator new(unsigned long) (/home/yixuan/doris/output/be/lib/doris_be+0x21658bdd) (BuildId: d7c9d2a3e104bf3f)
    #1 0x5641a2227e1e in doris::ExecEnv::_init(std::vector<doris::StorePath, std::allocator<doris::StorePath>> const&, std::set<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>, std::less<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>>, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>>> const&) /home/yixuan/doris/be/src/runtime/exec_env_init.cpp:214:20
    #2 0x5641a222612f in doris::ExecEnv::init(doris::ExecEnv*, std::vector<doris::StorePath, std::allocator<doris::StorePath>> const&, std::set<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>, std::less<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>>, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>>> const&) /home/yixuan/doris/be/src/runtime/exec_env_init.cpp:143:17
    #3 0x56419f39eb4a in main /home/yixuan/doris/be/src/service/doris_main.cpp:488:14
    #4 0x7f79c4b7f082 in __libc_start_main /build/glibc-SzIz7B/glibc-2.31/csu/../csu/libc-start.c:308:16

Thread T1220 (REPORT_TASK-151) created by T0 here:
    #0 0x56419f33fcad in pthread_create (/home/yixuan/doris/output/be/lib/doris_be+0x21601cad) (BuildId: d7c9d2a3e104bf3f)
    #1 0x5641a2d6389f in doris::Thread::start_thread(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const&, std::function<void ()> const&, unsigned long, scoped_refptr<doris::Thread>*) /home/yixuan/doris/be/src/util/thread.cpp:449:15
    #2 0x5641a1a56ebd in doris::Status doris::Thread::create<doris::ReportWorker::ReportWorker(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>, doris::TMasterInfo const&, int, std::function<void ()>)::$_0>(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const&, doris::ReportWorker::ReportWorker(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>, doris::TMasterInfo const&, int, std::function<void ()>)::$_0 const&, scoped_refptr<doris::Thread>*) /home/yixuan/doris/be/src/util/thread.h:50:16
    #3 0x5641a1a568ae in doris::ReportWorker::ReportWorker(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>, doris::TMasterInfo const&, int, std::function<void ()>) /home/yixuan/doris/be/src/agent/task_worker_pool.cpp:598:15
    #4 0x5641a290b69b in std::__detail::_MakeUniq<doris::ReportWorker>::__single_object std::make_unique<doris::ReportWorker, char const (&) [12], doris::TMasterInfo const&, int&, doris::AgentServer::start_workers(doris::StorageEngine&, doris::ExecEnv*)::$_18>(char const (&) [12], doris::TMasterInfo const&, int&, doris::AgentServer::start_workers(doris::StorageEngine&, doris::ExecEnv*)::$_18&&) /home/yixuan/ldb_tool/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/unique_ptr.h:1070:34
    #5 0x5641a29073b4 in doris::AgentServer::start_workers(doris::StorageEngine&, doris::ExecEnv*) /home/yixuan/doris/be/src/agent/agent_server.cpp:180:31
    #6 0x5641a28d40c9 in doris::BackendService::create_service(doris::StorageEngine&, doris::ExecEnv*, int, std::unique_ptr<doris::ThriftServer, std::default_delete<doris::ThriftServer>>*) /home/yixuan/doris/be/src/service/backend_service.cpp:379:29
    #7 0x56419f39f121 in main /home/yixuan/doris/be/src/service/doris_main.cpp:504:9
    #8 0x7f79c4b7f082 in __libc_start_main /build/glibc-SzIz7B/glibc-2.31/csu/../csu/libc-start.c:308:16

doris-robot · 2024-03-13T15:43:21Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

wyxxxcat · 2024-03-13T15:53:51Z

run buildall

doris-robot · 2024-03-13T16:26:20Z

TeamCity be ut coverage result:
Function Coverage: 35.00% (8576/24500)
Line Coverage: 26.76% (69474/259623)
Region Coverage: 26.03% (36079/138608)
Branch Coverage: 22.98% (18419/80148)
Coverage Report: http://coverage.selectdb-in.cc/coverage/899e5a4904a92fd1c7fb20ff48b0527bd73389cd_899e5a4904a92fd1c7fb20ff48b0527bd73389cd/report/index.html

doris-robot · 2024-03-13T16:29:36Z

TPC-H: Total hot run time: 37976 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 899e5a4904a92fd1c7fb20ff48b0527bd73389cd, data reload: false

------ Round 1 ----------------------------------
q1	17690	4261	4097	4097
q2	2018	153	145	145
q3	10594	1117	884	884
q4	6046	700	684	684
q5	7449	2709	2712	2709
q6	178	123	124	123
q7	1174	803	788	788
q8	9314	2028	1965	1965
q9	7175	6417	6371	6371
q10	8485	3471	3579	3471
q11	432	223	220	220
q12	708	298	293	293
q13	17786	2827	2880	2827
q14	282	238	246	238
q15	496	465	448	448
q16	497	387	388	387
q17	937	542	598	542
q18	7087	6472	6307	6307
q19	2728	1384	1419	1384
q20	520	281	275	275
q21	6694	3528	3510	3510
q22	346	308	334	308
Total cold run time: 108636 ms
Total hot run time: 37976 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4087	4068	4063	4063
q2	327	220	217	217
q3	2957	2770	2820	2770
q4	1819	1569	1582	1569
q5	5175	5211	5226	5211
q6	189	122	123	122
q7	2236	1821	1847	1821
q8	3145	3277	3280	3277
q9	8538	8544	8541	8541
q10	3679	3673	3623	3623
q11	536	442	449	442
q12	723	531	555	531
q13	16938	2858	2841	2841
q14	287	247	253	247
q15	479	445	445	445
q16	468	424	407	407
q17	1729	1469	1433	1433
q18	7588	7154	7156	7154
q19	1599	1558	1584	1558
q20	1884	1714	1696	1696
q21	4858	4623	4513	4513
q22	525	461	439	439
Total cold run time: 69766 ms
Total hot run time: 52920 ms

zclllyybb · 2024-03-13T21:40:53Z

fe/fe-core/src/main/java/org/apache/doris/tablefunction/ExternalFileTableValuedFunction.java

do not format this file

zclllyybb · 2024-03-13T21:41:48Z

be/src/service/doris_main.cpp

@@ -498,20 +499,22 @@ int main(int argc, char** argv) {
    doris::ThriftRpcHelper::setup(exec_env);
    // 1. thrift server with be_port
    std::unique_ptr<doris::ThriftServer> be_server;
-
+    std::shared_ptr<doris::BackendService> service = std::make_shared<doris::BackendService>(


why you move this here?

wyxxxcat · 2024-03-14T02:43:50Z

run buildall

doris-robot · 2024-03-14T03:09:27Z

TPC-H: Total hot run time: 38526 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit f5cfb379482642ef5078d2d011e8fcf2304e08df, data reload: false

------ Round 1 ----------------------------------
q1	17666	4308	4103	4103
q2	2024	160	149	149
q3	10671	1113	907	907
q4	8137	790	724	724
q5	7492	2808	2717	2717
q6	187	124	127	124
q7	1218	860	811	811
q8	9341	2042	2031	2031
q9	7161	6484	6413	6413
q10	8484	3456	3600	3456
q11	422	222	217	217
q12	634	308	298	298
q13	17793	2873	2896	2873
q14	278	247	251	247
q15	511	453	455	453
q16	500	402	401	401
q17	962	585	539	539
q18	7405	6563	6504	6504
q19	1585	1392	1474	1392
q20	559	297	285	285
q21	6608	3669	3568	3568
q22	369	314	315	314
Total cold run time: 110007 ms
Total hot run time: 38526 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4097	4071	4128	4071
q2	319	224	230	224
q3	2942	2863	2846	2846
q4	1901	1600	1611	1600
q5	5276	5311	5291	5291
q6	197	123	119	119
q7	2273	1845	1847	1845
q8	3168	3270	3305	3270
q9	8625	8613	8619	8613
q10	3718	3678	3661	3661
q11	552	442	437	437
q12	716	564	525	525
q13	16904	2905	2833	2833
q14	276	245	257	245
q15	475	445	455	445
q16	469	419	409	409
q17	1721	1470	1451	1451
q18	7664	7274	7163	7163
q19	1611	1501	1552	1501
q20	1884	1704	1707	1704
q21	4941	4710	4748	4710
q22	522	455	476	455
Total cold run time: 70251 ms
Total hot run time: 53418 ms

doris-robot · 2024-03-14T03:15:50Z

TeamCity be ut coverage result:
Function Coverage: 35.00% (8576/24500)
Line Coverage: 26.76% (69481/259623)
Region Coverage: 26.03% (36073/138608)
Branch Coverage: 22.99% (18425/80148)
Coverage Report: http://coverage.selectdb-in.cc/coverage/f5cfb379482642ef5078d2d011e8fcf2304e08df_f5cfb379482642ef5078d2d011e8fcf2304e08df/report/index.html

zclllyybb · 2024-03-14T10:30:45Z

run buildall

zclllyybb

LGTM

github-actions · 2024-03-14T10:32:27Z

PR approved by anyone and no changes requested.

HappenLee · 2024-03-14T10:43:36Z

be/src/service/doris_main.cpp

    if (doris::config::is_cloud_mode()) {
        EXIT_IF_ERROR(doris::CloudBackendService::create_service(
                exec_env->storage_engine().to_cloud(), exec_env, doris::config::be_port,
                &be_server));
    } else {
        EXIT_IF_ERROR(doris::BackendService::create_service(exec_env->storage_engine().to_local(),
                                                            exec_env, doris::config::be_port,
-                                                            &be_server));
+                                                            &be_server, service));
    }

    status = be_server->start();
    if (!status.ok()) {


use function do reduce the repeat code

doris-robot · 2024-03-14T11:24:06Z

TPC-H: Total hot run time: 38155 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit f5cfb379482642ef5078d2d011e8fcf2304e08df, data reload: false

------ Round 1 ----------------------------------
q1	17635	4262	4067	4067
q2	2017	156	145	145
q3	10597	1120	895	895
q4	6733	738	744	738
q5	7457	2732	2688	2688
q6	185	124	124	124
q7	1171	818	792	792
q8	9325	1983	1984	1983
q9	7229	6461	6427	6427
q10	8523	3501	3593	3501
q11	432	227	217	217
q12	672	292	294	292
q13	17787	2857	2869	2857
q14	273	248	241	241
q15	499	446	458	446
q16	508	384	384	384
q17	966	507	616	507
q18	7167	6439	6407	6407
q19	2979	1395	1456	1395
q20	545	296	277	277
q21	6547	3618	3473	3473
q22	347	311	299	299
Total cold run time: 109594 ms
Total hot run time: 38155 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4116	4060	4053	4053
q2	318	230	218	218
q3	2961	2836	2820	2820
q4	1841	1572	1531	1531
q5	5208	5216	5254	5216
q6	198	119	116	116
q7	2220	1844	1856	1844
q8	3164	3311	3286	3286
q9	8633	8578	8599	8578
q10	3702	3661	3644	3644
q11	556	429	434	429
q12	713	563	547	547
q13	16924	2877	2846	2846
q14	282	243	264	243
q15	484	446	446	446
q16	454	416	407	407
q17	1744	1456	1464	1456
q18	7476	7054	7141	7054
q19	1617	1524	1539	1524
q20	1928	1702	1679	1679
q21	4909	4772	4599	4599
q22	530	441	428	428
Total cold run time: 69978 ms
Total hot run time: 52964 ms

doris-robot · 2024-03-14T11:41:31Z

TeamCity be ut coverage result:
Function Coverage: 34.99% (8573/24500)
Line Coverage: 26.73% (69454/259805)
Region Coverage: 26.01% (36078/138692)
Branch Coverage: 22.97% (18420/80208)
Coverage Report: http://coverage.selectdb-in.cc/coverage/f5cfb379482642ef5078d2d011e8fcf2304e08df_f5cfb379482642ef5078d2d011e8fcf2304e08df/report/index.html

github-actions · 2024-03-14T13:14:13Z

`sh-checker report`

To get the full details, please check in the job output.

shellcheck errors


'shellcheck ' returned error 1 finding the following syntactical issues:

----------

In build.sh line 285:
    local submodule_path=$1
    ^---------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In build.sh line 286:
    local submodule_name=$2
    ^---------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In build.sh line 287:
    local archive_url=$3
    ^------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In build.sh line 289:
    set +e
    ^----^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In build.sh line 290:
    cd "${DORIS_HOME}"
    ^----------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In build.sh line 291:
    echo "Update ${submodule_name} submodule ..."
    ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In build.sh line 292:
    git submodule update --init --recursive "${submodule_path}"
    ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In build.sh line 293:
    exit_code=$?
    ^----------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In build.sh line 294:
    if [[ "${exit_code}" -eq 0 ]]; then
    ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
       ^------------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In build.sh line 295:
        cd "${submodule_path}"
        ^--------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In build.sh line 296:
        submodule_commit_id=$(git rev-parse HEAD)
        ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
                              ^----------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In build.sh line 297:
        cd -
        ^--^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In build.sh line 298:
        expect_submodule_commit_id=$(git ls-tree HEAD "${submodule_path}" | awk '{print $3}')
        ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
                                     ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In build.sh line 299:
        echo "Current commit ID of ${submodule_name} submodule: ${submodule_commit_id}, expected is ${expect_submodule_commit_id}"
        ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In build.sh line 301:
    set -e
    ^----^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In build.sh line 302:
    if [[ "${exit_code}" -ne 0 ]]; then
    ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
       ^------------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In build.sh line 303:
        set +e
        ^----^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In build.sh line 305:
        submodule_commit=$(git ls-tree HEAD "${submodule_path}" | awk '{print $3}')
        ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
                           ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In build.sh line 306:
        exit_code=$?
        ^----------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In build.sh line 307:
        if [[ "${exit_code}" = "0" ]]; then
        ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
           ^------------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In build.sh line 308:
            commit_specific_url=$(echo "${archive_url}" | sed "s/refs\/heads/${submodule_commit}/")
            ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
                                  ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In build.sh line 310:
            commit_specific_url="${archive_url}"
            ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In build.sh line 312:
        set -e
        ^----^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In build.sh line 313:
        echo "Update ${submodule_name} submodule failed, start to download and extract ${commit_specific_url}"
        ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In build.sh line 315:
        mkdir -p "${DORIS_HOME}/${submodule_path}"
        ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In build.sh line 316:
        curl -L "${commit_specific_url}" | tar -xz -C "${DORIS_HOME}/${submodule_path}" --strip-components=1
        ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).

For more information:
  https://www.shellcheck.net/wiki/SC2317 -- Command appears to be unreachable...
----------

You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
  # shellcheck disable=NNNN
above the line that contains the issue, where NNNN is the error code;
3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.

shfmt errors

'shfmt ' found no issues.

wyxxxcat · 2024-03-14T13:18:51Z

run buildall

doris-robot · 2024-03-14T13:52:29Z

TeamCity be ut coverage result:
Function Coverage: 34.99% (8573/24500)
Line Coverage: 26.73% (69457/259805)
Region Coverage: 26.02% (36081/138692)
Branch Coverage: 22.97% (18422/80208)
Coverage Report: http://coverage.selectdb-in.cc/coverage/7fe22f55fd517bc33be63a2c646ec81579c3b6d3_7fe22f55fd517bc33be63a2c646ec81579c3b6d3/report/index.html

doris-robot · 2024-03-14T14:01:21Z

TPC-H: Total hot run time: 38019 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 7fe22f55fd517bc33be63a2c646ec81579c3b6d3, data reload: false

------ Round 1 ----------------------------------
q1	17673	4177	4111	4111
q2	2016	148	157	148
q3	10591	1088	900	900
q4	7436	709	706	706
q5	7485	2552	2562	2552
q6	183	123	121	121
q7	1171	827	791	791
q8	9331	2015	1982	1982
q9	7258	6413	6336	6336
q10	8497	3478	3616	3478
q11	434	228	222	222
q12	729	295	286	286
q13	18111	2813	2861	2813
q14	267	238	243	238
q15	510	449	450	449
q16	508	386	388	386
q17	934	574	541	541
q18	7124	6413	6478	6413
q19	1567	1415	1397	1397
q20	554	280	286	280
q21	6183	3570	3606	3570
q22	358	299	323	299
Total cold run time: 108920 ms
Total hot run time: 38019 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4099	4036	4036	4036
q2	330	220	220	220
q3	2933	2853	2807	2807
q4	1828	1516	1526	1516
q5	5214	5246	5249	5246
q6	194	119	116	116
q7	2252	1855	1838	1838
q8	3124	3238	3252	3238
q9	8509	8522	8461	8461
q10	3633	3641	3635	3635
q11	543	432	431	431
q12	742	571	564	564
q13	16947	2866	2828	2828
q14	275	240	241	240
q15	481	437	451	437
q16	463	429	418	418
q17	1731	1470	1462	1462
q18	7464	7217	7029	7029
q19	1585	1544	1500	1500
q20	1909	1691	1706	1691
q21	4872	4837	4712	4712
q22	517	471	453	453
Total cold run time: 69645 ms
Total hot run time: 52878 ms

zclllyybb

LGTM

HappenLee

LGTM

github-actions · 2024-03-20T11:27:58Z

PR approved by at least one committer and no changes requested.

zclllyybb reviewed Mar 13, 2024

View reviewed changes

wyxxxcat force-pushed the heartbeat branch 3 times, most recently from 15c32cc to f5cfb37 Compare March 14, 2024 02:42

wyxxxcat marked this pull request as ready for review March 14, 2024 09:16

zclllyybb approved these changes Mar 14, 2024

View reviewed changes

github-actions bot added the reviewed label Mar 14, 2024

HappenLee reviewed Mar 14, 2024

View reviewed changes

wyxxxcat force-pushed the heartbeat branch 2 times, most recently from ab1c298 to 236a352 Compare March 14, 2024 13:13

fix

7fe22f5

wyxxxcat force-pushed the heartbeat branch from 236a352 to 7fe22f5 Compare March 14, 2024 13:17

zclllyybb approved these changes Mar 14, 2024

View reviewed changes

wyxxxcat requested a review from HappenLee March 16, 2024 09:39

HappenLee approved these changes Mar 20, 2024

View reviewed changes

github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 20, 2024

BiteTheDDDDt merged commit b8485fa into apache:master Mar 20, 2024
26 of 29 checks passed

wyxxxcat deleted the heartbeat branch March 21, 2024 03:33

yiguolei added the 2.1.0-conflict label Mar 21, 2024

This was referenced Mar 27, 2024

[fix](arrow-flight) Fix arrow flight sql compatible with JDK 17 and upgrade arrow 15.0.2 #32796

Merged

[fix](grace-exit) Stop incorrectly of reportwork cause heap use after free #32929

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Bug] Stop incorrectly of reportwork cause heap use after free #32205

[Bug] Stop incorrectly of reportwork cause heap use after free #32205

wyxxxcat commented Mar 13, 2024 •

edited

doris-robot commented Mar 13, 2024

wyxxxcat commented Mar 13, 2024

doris-robot commented Mar 13, 2024

doris-robot commented Mar 13, 2024

zclllyybb Mar 13, 2024

zclllyybb Mar 13, 2024

zclllyybb Mar 14, 2024

wyxxxcat commented Mar 14, 2024

doris-robot commented Mar 14, 2024

doris-robot commented Mar 14, 2024

zclllyybb commented Mar 14, 2024

zclllyybb left a comment

github-actions bot commented Mar 14, 2024

HappenLee Mar 14, 2024

doris-robot commented Mar 14, 2024

doris-robot commented Mar 14, 2024

github-actions bot commented Mar 14, 2024

wyxxxcat commented Mar 14, 2024

doris-robot commented Mar 14, 2024

doris-robot commented Mar 14, 2024

zclllyybb left a comment

HappenLee left a comment

github-actions bot commented Mar 20, 2024

[Bug] Stop incorrectly of reportwork cause heap use after free #32205

[Bug] Stop incorrectly of reportwork cause heap use after free #32205

Conversation

wyxxxcat commented Mar 13, 2024 • edited

Proposed changes

Further comments

doris-robot commented Mar 13, 2024

wyxxxcat commented Mar 13, 2024

doris-robot commented Mar 13, 2024

doris-robot commented Mar 13, 2024

zclllyybb Mar 13, 2024

Choose a reason for hiding this comment

zclllyybb Mar 13, 2024

Choose a reason for hiding this comment

zclllyybb Mar 14, 2024

Choose a reason for hiding this comment

wyxxxcat commented Mar 14, 2024

doris-robot commented Mar 14, 2024

doris-robot commented Mar 14, 2024

zclllyybb commented Mar 14, 2024

zclllyybb left a comment

Choose a reason for hiding this comment

github-actions bot commented Mar 14, 2024

HappenLee Mar 14, 2024

Choose a reason for hiding this comment

doris-robot commented Mar 14, 2024

doris-robot commented Mar 14, 2024

github-actions bot commented Mar 14, 2024

sh-checker report

wyxxxcat commented Mar 14, 2024

doris-robot commented Mar 14, 2024

doris-robot commented Mar 14, 2024

zclllyybb left a comment

Choose a reason for hiding this comment

HappenLee left a comment

Choose a reason for hiding this comment

github-actions bot commented Mar 20, 2024

wyxxxcat commented Mar 13, 2024 •

edited

`sh-checker report`