New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix](Outfile) Fix the column type mapping in the orc/parquet file format #32281
Conversation
Thank you for your contribution to Apache Doris. |
run buildall |
TPC-H: Total hot run time: 38252 ms
|
TeamCity be ut coverage result: |
3694999
to
c95b67f
Compare
run buildall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
@@ -17,6 +17,8 @@ | |||
|
|||
#pragma once | |||
|
|||
#include <cctz/time_zone.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: 'cctz/time_zone.h' file not found [clang-diagnostic-error]
#include <cctz/time_zone.h>
^
@@ -18,6 +18,7 @@ | |||
#pragma once | |||
|
|||
#include <arrow/type.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: 'arrow/type.h' file not found [clang-diagnostic-error]
#include <arrow/type.h>
^
@@ -17,6 +17,8 @@ | |||
|
|||
#pragma once | |||
|
|||
#include <cctz/time_zone.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: 'cctz/time_zone.h' file not found [clang-diagnostic-error]
#include <cctz/time_zone.h>
^
TPC-H: Total hot run time: 38306 ms
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Need to update the document in |
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
run feut |
run buildall |
TPC-H: Total hot run time: 38368 ms
|
TeamCity be ut coverage result: |
run buildall |
2 similar comments
run buildall |
run buildall |
TeamCity be ut coverage result: |
run buildall |
TeamCity be ut coverage result: |
fd6dedc
to
95a33b6
Compare
run buildall |
TeamCity be ut coverage result: |
run external |
run p0 |
1 similar comment
run p0 |
run buildall |
TeamCity be ut coverage result: |
PR approved by at least one committer and no changes requested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…rmat (#32281) | Doris Type | Orc Type | Parquet Type | |---------------------|--------------------|------------------------| | Date | Long (logical: DATE) | int32 (Logical: Date) | | DateTime | TIMESTAMP (logical: TIMESTAMP) | int96 |
…rmat (apache#32281) | Doris Type | Orc Type | Parquet Type | |---------------------|--------------------|------------------------| | Date | Long (logical: DATE) | int32 (Logical: Date) | | DateTime | TIMESTAMP (logical: TIMESTAMP) | int96 |
Proposed changes
Issue Number: close #xxx
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...