Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature](proxy-protocol) Support proxy protocol v1 #32338

Merged
merged 9 commits into from
Mar 18, 2024

Conversation

morningman
Copy link
Contributor

@morningman morningman commented Mar 17, 2024

Proposed changes

Issue Number: close #xxx

Enable proxy protocol to support IP transparency.
See: IP Transparency in https://github.com/apache/doris/blob/f57387b502035fa138d946936e63d1c55e7d1ff4/docs/en/docs/admin-manual/cluster-management/load-balancing.md
for details

Further comments

Only support proxy protocol v1, I think this is enough.
HAProxy support both, Nginx support only V1.

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

@morningman morningman marked this pull request as ready for review March 17, 2024 08:52
@morningman morningman changed the title [feature](prox-protocol) Support proxy protocol v1 [feature](proxy-protocol) Support proxy protocol v1 Mar 17, 2024
@morningman
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 38403 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit f57387b502035fa138d946936e63d1c55e7d1ff4, data reload: false

------ Round 1 ----------------------------------
q1	17658	4178	4113	4113
q2	2019	151	144	144
q3	10604	1055	897	897
q4	7783	739	740	739
q5	7638	2683	2676	2676
q6	186	125	122	122
q7	1150	804	798	798
q8	9336	2006	2004	2004
q9	7256	6472	6489	6472
q10	8513	3503	3692	3503
q11	439	236	223	223
q12	657	290	290	290
q13	18117	2881	2889	2881
q14	278	248	254	248
q15	504	464	448	448
q16	522	394	392	392
q17	950	515	545	515
q18	7041	6461	6491	6461
q19	3185	1409	1416	1409
q20	543	280	273	273
q21	6220	3483	3561	3483
q22	376	341	312	312
Total cold run time: 110975 ms
Total hot run time: 38403 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4245	4233	4231	4231
q2	320	231	248	231
q3	3123	2946	2989	2946
q4	1915	1612	1649	1612
q5	5406	5362	5305	5305
q6	193	115	114	114
q7	2227	1868	1854	1854
q8	3125	3329	3278	3278
q9	8494	8483	8524	8483
q10	3677	3665	3578	3578
q11	540	453	437	437
q12	729	546	565	546
q13	16939	2839	2848	2839
q14	264	249	253	249
q15	482	455	445	445
q16	446	400	401	400
q17	1715	1469	1457	1457
q18	7428	7217	7020	7020
q19	3473	1532	1540	1532
q20	1890	1680	1683	1680
q21	4839	4622	4633	4622
q22	527	451	442	442
Total cold run time: 71997 ms
Total hot run time: 53301 ms

@morningman
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 38392 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 489d5888800bfd322da986f19fb2913347632db1, data reload: false

------ Round 1 ----------------------------------
q1	17643	4290	4300	4290
q2	2028	155	147	147
q3	10644	1076	909	909
q4	7433	717	717	717
q5	7451	2615	2606	2606
q6	185	122	122	122
q7	1220	817	803	803
q8	9357	1980	2011	1980
q9	7208	6366	6438	6366
q10	8447	3460	3592	3460
q11	418	218	219	218
q12	622	315	299	299
q13	17813	2840	2846	2840
q14	279	247	253	247
q15	498	450	458	450
q16	483	395	396	395
q17	937	542	524	524
q18	7465	6513	6451	6451
q19	4566	1387	1414	1387
q20	567	290	288	288
q21	6245	3639	3582	3582
q22	354	311	312	311
Total cold run time: 111863 ms
Total hot run time: 38392 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4171	4080	4088	4080
q2	315	233	221	221
q3	2977	2835	2795	2795
q4	1833	1575	1567	1567
q5	5253	5276	5249	5249
q6	192	115	116	115
q7	2269	1895	1904	1895
q8	3134	3316	3260	3260
q9	8503	8545	8520	8520
q10	3659	3698	3701	3698
q11	529	426	453	426
q12	717	540	583	540
q13	16902	2847	2839	2839
q14	270	248	251	248
q15	474	447	453	447
q16	447	413	406	406
q17	1739	1505	1470	1470
q18	7498	7266	7134	7134
q19	1617	1552	1521	1521
q20	1895	1710	1714	1710
q21	4968	4730	4686	4686
q22	534	461	483	461
Total cold run time: 69896 ms
Total hot run time: 53288 ms

Copy link
Contributor

PR approved by anyone and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 18, 2024
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@morningman morningman merged commit 546f689 into apache:master Mar 18, 2024
26 of 29 checks passed
morningman added a commit to morningman/doris that referenced this pull request Mar 18, 2024
morningman added a commit to morningman/doris that referenced this pull request Mar 18, 2024
morningman added a commit to morningman/doris that referenced this pull request Mar 18, 2024
morningman added a commit to morningman/doris that referenced this pull request Mar 18, 2024
@xiaokang xiaokang added the usercase Important user case type label label Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.7-merged reviewed usercase Important user case type label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants