Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix](smooth-upgrade) Fix right function incompatibility when upgrade from 2.0 to 2.1 #32444

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

zhangstar333
Copy link
Contributor

Proposed changes

It seems there are some typos in the writing, should call SubstringUtilOld in FunctionRightOld function.

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@zhangstar333
Copy link
Contributor Author

run buildall

Copy link
Contributor

@zclllyybb zclllyybb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 35.24% (8699/24687)
Line Coverage: 27.06% (71154/262908)
Region Coverage: 26.31% (36901/140268)
Branch Coverage: 23.23% (18877/81268)
Coverage Report: http://coverage.selectdb-in.cc/coverage/a6909aa35da2c97e1aec44bfaf1d7258f6ecc408_a6909aa35da2c97e1aec44bfaf1d7258f6ecc408/report/index.html

Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 19, 2024
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@zhangstar333 zhangstar333 merged commit a2df10e into apache:master Mar 19, 2024
25 of 31 checks passed
XuJianxu pushed a commit to XuJianxu/doris that referenced this pull request Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants