Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](join) the result of left semi join with empty right side should be false instead of null #32477

Merged
merged 1 commit into from Mar 22, 2024
Merged

[fix](join) the result of left semi join with empty right side should be false instead of null #32477

merged 1 commit into from Mar 22, 2024

Conversation

mrhhsg
Copy link
Member

@mrhhsg mrhhsg commented Mar 19, 2024

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@mrhhsg
Copy link
Member Author

mrhhsg commented Mar 19, 2024

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 35.32% (8728/24710)
Line Coverage: 27.13% (71390/263142)
Region Coverage: 26.38% (37042/140412)
Branch Coverage: 23.27% (18936/81360)
Coverage Report: http://coverage.selectdb-in.cc/coverage/3cc7cba1536cf0e127ba37fa3307227218416729_3cc7cba1536cf0e127ba37fa3307227218416729/report/index.html

@mrhhsg
Copy link
Member Author

mrhhsg commented Mar 19, 2024

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 35.32% (8728/24713)
Line Coverage: 27.13% (71405/263201)
Region Coverage: 26.38% (37051/140455)
Branch Coverage: 23.28% (18946/81384)
Coverage Report: http://coverage.selectdb-in.cc/coverage/3cc7cba1536cf0e127ba37fa3307227218416729_3cc7cba1536cf0e127ba37fa3307227218416729/report/index.html

@yiguolei
Copy link
Contributor

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 35.26% (8728/24751)
Line Coverage: 27.08% (71461/263894)
Region Coverage: 26.31% (37066/140877)
Branch Coverage: 23.22% (18955/81620)
Coverage Report: http://coverage.selectdb-in.cc/coverage/750e1c49f745370983cd6c87c61165453c86251e_750e1c49f745370983cd6c87c61165453c86251e/report/index.html

@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Mar 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@mrhhsg
Copy link
Member Author

mrhhsg commented Mar 21, 2024

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 37854 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 750e1c49f745370983cd6c87c61165453c86251e, data reload: false

------ Round 1 ----------------------------------
q1	17653	4390	4233	4233
q2	2088	158	146	146
q3	11725	1126	1239	1126
q4	10770	772	826	772
q5	7882	3076	3006	3006
q6	205	128	129	128
q7	1090	604	587	587
q8	9478	2070	2023	2023
q9	7304	6635	6603	6603
q10	9403	3219	3554	3219
q11	442	225	216	216
q12	367	194	186	186
q13	17805	2883	2881	2881
q14	231	202	208	202
q15	519	452	449	449
q16	451	359	354	354
q17	962	537	626	537
q18	7454	6598	6401	6401
q19	4269	1433	1488	1433
q20	541	260	249	249
q21	3625	2920	2804	2804
q22	352	299	301	299
Total cold run time: 114616 ms
Total hot run time: 37854 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4168	4078	4110	4078
q2	324	237	234	234
q3	3080	2875	2857	2857
q4	1907	1570	1613	1570
q5	5240	5271	5283	5271
q6	199	115	118	115
q7	2243	1851	1818	1818
q8	3169	3306	3323	3306
q9	8600	8586	8609	8586
q10	3733	3712	3662	3662
q11	554	440	446	440
q12	711	562	566	562
q13	16915	2873	2848	2848
q14	270	270	252	252
q15	481	444	446	444
q16	448	419	428	419
q17	1745	1493	1462	1462
q18	7485	7157	7200	7157
q19	1618	1532	1569	1532
q20	1907	1707	1687	1687
q21	4863	4754	4711	4711
q22	540	457	461	457
Total cold run time: 70200 ms
Total hot run time: 53468 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 180560 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 750e1c49f745370983cd6c87c61165453c86251e, data reload: false

query1	921	352	343	343
query2	7367	1981	1905	1905
query3	6709	212	219	212
query4	31274	20730	20724	20724
query5	4549	435	420	420
query6	271	170	180	170
query7	4630	293	286	286
query8	241	176	169	169
query9	9920	2262	2248	2248
query10	460	241	258	241
query11	17052	14244	14301	14244
query12	135	93	83	83
query13	1627	409	423	409
query14	12420	10815	10410	10410
query15	266	220	191	191
query16	8140	257	259	257
query17	1927	583	546	546
query18	2048	289	281	281
query19	246	149	153	149
query20	94	86	86	86
query21	198	130	135	130
query22	4649	4472	4392	4392
query23	31639	30756	31079	30756
query24	11698	2814	2770	2770
query25	673	385	379	379
query26	1808	153	155	153
query27	3072	348	351	348
query28	8145	1876	1864	1864
query29	1043	658	627	627
query30	310	149	147	147
query31	956	742	728	728
query32	100	59	54	54
query33	769	253	254	253
query34	1081	470	469	469
query35	892	614	605	605
query36	1029	845	875	845
query37	273	80	81	80
query38	3601	3459	3405	3405
query39	1452	1384	1398	1384
query40	296	115	112	112
query41	49	49	47	47
query42	104	98	95	95
query43	465	442	453	442
query44	1169	706	723	706
query45	281	265	256	256
query46	1079	674	690	674
query47	1659	1591	1597	1591
query48	443	358	361	358
query49	1235	353	337	337
query50	762	368	371	368
query51	6721	6545	6655	6545
query52	103	96	95	95
query53	341	285	276	276
query54	333	245	259	245
query55	85	79	83	79
query56	251	236	243	236
query57	1096	1022	1023	1022
query58	236	204	205	204
query59	2738	2529	2545	2529
query60	271	247	265	247
query61	119	113	111	111
query62	603	407	402	402
query63	300	276	279	276
query64	6304	3882	3943	3882
query65	3092	3018	2991	2991
query66	1398	341	339	339
query67	15060	14416	14643	14416
query68	10400	520	532	520
query69	689	374	380	374
query70	1354	1127	1148	1127
query71	526	286	282	282
query72	7009	2682	2497	2497
query73	1637	314	315	314
query74	8124	6552	6599	6552
query75	5094	2859	2883	2859
query76	5844	894	920	894
query77	655	263	254	254
query78	10330	9570	9623	9570
query79	11482	511	522	511
query80	1715	390	378	378
query81	493	212	204	204
query82	327	201	202	201
query83	219	142	145	142
query84	292	80	78	78
query85	1102	338	313	313
query86	350	295	299	295
query87	3731	3487	3573	3487
query88	5134	2280	2279	2279
query89	472	358	357	357
query90	2045	179	175	175
query91	166	150	149	149
query92	61	47	49	47
query93	6213	489	485	485
query94	1318	176	174	174
query95	437	329	331	329
query96	598	277	269	269
query97	3051	2875	2854	2854
query98	232	213	207	207
query99	1054	739	772	739
Total cold run time: 322432 ms
Total hot run time: 180560 ms

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 35.27% (8730/24749)
Line Coverage: 27.09% (71495/263912)
Region Coverage: 26.32% (37080/140907)
Branch Coverage: 23.23% (18964/81642)
Coverage Report: http://coverage.selectdb-in.cc/coverage/750e1c49f745370983cd6c87c61165453c86251e_750e1c49f745370983cd6c87c61165453c86251e/report/index.html

@doris-robot
Copy link

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit 750e1c49f745370983cd6c87c61165453c86251e with default session variables
Stream load json:         18 seconds loaded 2358488459 Bytes, about 124 MB/s
Stream load orc:          59 seconds loaded 1101869774 Bytes, about 17 MB/s
Stream load parquet:      32 seconds loaded 861443392 Bytes, about 25 MB/s
Insert into select:       20.3 seconds inserted 10000000 Rows, about 492K ops/s

HappenLee
HappenLee approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mrhhsg mrhhsg merged commit 7e42fee into apache:master Mar 22, 2024
25 of 30 checks passed
@mrhhsg mrhhsg deleted the fix_left_semi branch March 22, 2024 01:35
yiguolei pushed a commit that referenced this pull request Mar 22, 2024
@mrhhsg @Doris-Extras
[fix](join) the result of left semi join with empty right side should…
66336e5 
… be false, not null (#32477)
@yiguolei yiguolei mentioned this pull request Mar 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BiteTheDDDDt BiteTheDDDDt BiteTheDDDDt approved these changes

@HappenLee HappenLee HappenLee approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mrhhsg @doris-robot @yiguolei @BiteTheDDDDt @HappenLee