[bug](udaf) fix memory leak in the java udaf #32630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| ~AggregateJavaUdafData() { | ||
| ~AggregateJavaUdafData() = default; | ||
|
|
||
| Status close_and_delete_object() { |
There was a problem hiding this comment.
warning: method 'close_and_delete_object' can be made static [readability-convert-member-functions-to-static]
Suggested change
| Status close_and_delete_object() { | |
| static Status close_and_delete_object() { |
TPC-H: Total hot run time: 37798 ms |
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 180165 ms |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
HappenLee
reviewed
Mar 22, 2024
|
run buildall |
TPC-H: Total hot run time: 38070 ms |
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 181824 ms |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
BiteTheDDDDt
approved these changes
Mar 22, 2024
zhangstar333
added a commit
to zhangstar333/incubator-doris
that referenced
this pull request
Mar 22, 2024
fix memory leak in the java udaf
xiaokang
pushed a commit
that referenced
this pull request
Mar 22, 2024
yiguolei
pushed a commit
that referenced
this pull request
Mar 24, 2024
fix memory leak in the java udaf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
before:
if someone call destroy function with place,
when place != _exec_place maybe do nothing ,
when place == _exec_place, do destroy of all place,
as we not want call JNI every times, so will destroy all place at once.
but not call this->data(place).~Data(); this maybe not release the use memory of std::string serialize_data.
Issue Number: close #xxx
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...