-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug](schame-change) fix wrong result after reorder mor table #32839
Conversation
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
run buildall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
virtual ~ColumnMapping() = default; | ||
|
||
bool has_reference() const { return expr != nullptr || ref_column >= 0; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: function 'has_reference' should be marked [[nodiscard]] [modernize-use-nodiscard]
bool has_reference() const { return expr != nullptr || ref_column >= 0; } | |
[[nodiscard]] bool has_reference() const { return expr != nullptr || ref_column >= 0; } |
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 50318 ms
|
TPC-DS: Total hot run time: 201784 ms
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
|
Proposed changes
pick #29045 and part of #28135
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...