[refine](Operator) When _stop_emplace_flag is not set to true, perform batch processing on the block. #33173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 38418 ms |
TPC-DS: Total hot run time: 182907 ms |
ClickBench: Total hot run time: 29.67 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
zhangstar333
previously approved these changes
Apr 3, 2024
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
|
run buildall |
github-actions
bot
removed
the
approved
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 38654 ms |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 38869 ms |
TPC-DS: Total hot run time: 182934 ms |
|
run buildall |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| return Status::OK(); | ||
| } | ||
|
|
||
| bool DistinctStreamingAggOperatorX::need_more_input_data(RuntimeState* state) const { | ||
| auto& local_state = get_local_state(state); | ||
| return local_state._aggregated_block->empty() && !local_state._child_eos && | ||
| (_limit == -1 || local_state._output_distinct_rows < _limit); | ||
| const bool need_batch = local_state._stop_emplace_flag |
There was a problem hiding this comment.
warning: method 'need_more_input_data' can be made static [readability-convert-member-functions-to-static]
Suggested change
| const bool need_batch = local_state._stop_emplace_flag | |
| bool DistinctStreamingAggOperatorX::need_more_input_data(RuntimeState* state) { |
be/src/pipeline/exec/distinct_streaming_aggregation_operator.h:105:
- bool need_more_input_data(RuntimeState* state) const override;
+ static bool need_more_input_data(RuntimeState* state) override;
|
TeamCity be ut coverage result: |
|
run buildall |
| return Status::OK(); | ||
| } | ||
|
|
||
| Status DistinctStreamingAggLocalState::open(RuntimeState* state) { |
There was a problem hiding this comment.
warning: method 'open' can be made static [readability-convert-member-functions-to-static]
Suggested change
| Status DistinctStreamingAggLocalState::open(RuntimeState* state) { | |
| static Status DistinctStreamingAggLocalState::open(RuntimeState* state) { |
|
run buildall |
|
TeamCity be ut coverage result: |
|
run buildall |
|
TeamCity be ut coverage result: |
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
|
run buildall |
|
TeamCity be ut coverage result: |
|
run buildall |
TPC-H: Total hot run time: 39195 ms |
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 186973 ms |
ClickBench: Total hot run time: 31.27 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
Gabriel39
approved these changes
Apr 15, 2024
yiguolei
pushed a commit
that referenced
this pull request
Apr 16, 2024
…m batch processing on the block. (#33173)
yiguolei
pushed a commit
that referenced
this pull request
Apr 17, 2024
…m batch processing on the block. (#33173)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The setting of _stop_emplace_flag is a heuristic operation.
Previously, there was no batch processing on PipelineX (push one block, then pull one block), so it was easily misled by the first few small blocks.
Therefore, batch processing is adopted here, and the first two values of STREAMING_HT_MIN_REDUCTION are set to 0.
Only when enough data is obtained will _stop_emplace_flag be set to true.
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...