-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement](function) Support Overlay function #33243
base: master
Are you sure you want to change the base?
Conversation
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
run buildall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
TeamCity be ut coverage result: |
run buildall |
TeamCity be ut coverage result: |
run buildall |
TPC-H: Total hot run time: 39104 ms
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 180714 ms
|
ClickBench: Total hot run time: 30.08 s
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
|
run p0 |
run buildall |
TPC-H: Total hot run time: 38679 ms
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 179631 ms
|
ClickBench: Total hot run time: 29.3 s
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
|
run buildall |
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 38464 ms
|
TeamCity be ut coverage result: |
run buildall |
run buildall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
INT(5), | ||
VARCHAR("9090"), | ||
}, | ||
{Null()}}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
ypes, data_set);
^
Additional context
be/test/vec/function/function_string_test.cpp:1360: 243 lines including whitespace and comments (threshold 80)
ypes, data_set);
^
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
INT(5), | ||
VARCHAR("9090"), | ||
}, | ||
{Null()}}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
ypes, data_set);
^
Additional context
be/test/vec/function/function_string_test.cpp:1360: 96 lines including whitespace and comments (threshold 80)
ypes, data_set);
^
TeamCity be ut coverage result: |
...-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/scalar/Overlay.java
Outdated
Show resolved
Hide resolved
TPC-DS: Total hot run time: 187108 ms
|
run buildall |
TPC-H: Total hot run time: 40600 ms
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 185798 ms
|
run buildall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
{{ | ||
VARCHAR("Test"), | ||
Null(), | ||
INT(5), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
^
Additional context
be/test/vec/function/function_string_test.cpp:2787: 96 lines including whitespace and comments (threshold 80)
^
TeamCity be ut coverage result: |
run buildall |
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 41644 ms
|
TPC-DS: Total hot run time: 187509 ms
|
run buildall |
TeamCity be ut coverage result: |
run p0 |
run performance |
Proposed changes
Issue Number: close #33094
Add Function Overlay for doris
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...