-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature][Enhancement](hive-writer) Add hive-writer runtime profiles, change output file names and Use table_sink_partition_write_max_partition_nums_per_writer
.
#33245
Conversation
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
run buildall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
@@ -68,114 +81,154 @@ Status VHiveTableWriter::open(RuntimeState* state, RuntimeProfile* profile) { | |||
} | |||
|
|||
Status VHiveTableWriter::write(vectorized::Block& block) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: function 'write' has cognitive complexity of 79 (threshold 50) [readability-function-cognitive-complexity]
Status VHiveTableWriter::write(vectorized::Block& block) {
^
Additional context
be/src/vec/sink/writer/vhive_table_writer.cpp:88: +1, including nesting penalty of 0, nesting level increased to 1
if (_partition_columns_input_index.empty()) {
^
be/src/vec/sink/writer/vhive_table_writer.cpp:93: +2, including nesting penalty of 1, nesting level increased to 2
if (writer_iter == _partitions_to_writers.end()) {
^
be/src/vec/sink/writer/vhive_table_writer.cpp:96: +3, including nesting penalty of 2, nesting level increased to 3
} catch (doris::Exception& e) {
^
be/src/vec/sink/writer/vhive_table_writer.cpp:100: +3, including nesting penalty of 2, nesting level increased to 3
RETURN_IF_ERROR(writer->open(_state, _profile));
^
be/src/common/status.h:541: expanded from macro 'RETURN_IF_ERROR'
do { \
^
be/src/vec/sink/writer/vhive_table_writer.cpp:100: +4, including nesting penalty of 3, nesting level increased to 4
RETURN_IF_ERROR(writer->open(_state, _profile));
^
be/src/common/status.h:543: expanded from macro 'RETURN_IF_ERROR'
if (UNLIKELY(!_status_.ok())) { \
^
be/src/vec/sink/writer/vhive_table_writer.cpp:102: +1, nesting level increased to 2
} else {
^
be/src/vec/sink/writer/vhive_table_writer.cpp:103: +3, including nesting penalty of 2, nesting level increased to 3
if (writer_iter->second->written_len() > config::hive_sink_max_file_size) {
^
be/src/vec/sink/writer/vhive_table_writer.cpp:114: +4, including nesting penalty of 3, nesting level increased to 4
} catch (doris::Exception& e) {
^
be/src/vec/sink/writer/vhive_table_writer.cpp:118: +4, including nesting penalty of 3, nesting level increased to 4
RETURN_IF_ERROR(writer->open(_state, _profile));
^
be/src/common/status.h:541: expanded from macro 'RETURN_IF_ERROR'
do { \
^
be/src/vec/sink/writer/vhive_table_writer.cpp:118: +5, including nesting penalty of 4, nesting level increased to 5
RETURN_IF_ERROR(writer->open(_state, _profile));
^
be/src/common/status.h:543: expanded from macro 'RETURN_IF_ERROR'
if (UNLIKELY(!_status_.ok())) { \
^
be/src/vec/sink/writer/vhive_table_writer.cpp:119: +1, nesting level increased to 3
} else {
^
be/src/vec/sink/writer/vhive_table_writer.cpp:125: +2, including nesting penalty of 1, nesting level increased to 2
RETURN_IF_ERROR(writer->write(block));
^
be/src/common/status.h:541: expanded from macro 'RETURN_IF_ERROR'
do { \
^
be/src/vec/sink/writer/vhive_table_writer.cpp:125: +3, including nesting penalty of 2, nesting level increased to 3
RETURN_IF_ERROR(writer->write(block));
^
be/src/common/status.h:543: expanded from macro 'RETURN_IF_ERROR'
if (UNLIKELY(!_status_.ok())) { \
^
be/src/vec/sink/writer/vhive_table_writer.cpp:131: +1, including nesting penalty of 0, nesting level increased to 1
for (int i = 0; i < block.rows(); ++i) {
^
be/src/vec/sink/writer/vhive_table_writer.cpp:135: +2, including nesting penalty of 1, nesting level increased to 2
} catch (doris::Exception& e) {
^
be/src/vec/sink/writer/vhive_table_writer.cpp:142: nesting level increased to 2
[&](const std::string& partition_name, int position,
^
be/src/vec/sink/writer/vhive_table_writer.cpp:148: +3, including nesting penalty of 2, nesting level increased to 3
RETURN_IF_ERROR(writer->open(_state, _profile));
^
be/src/common/status.h:541: expanded from macro 'RETURN_IF_ERROR'
do { \
^
be/src/vec/sink/writer/vhive_table_writer.cpp:148: +4, including nesting penalty of 3, nesting level increased to 4
RETURN_IF_ERROR(writer->open(_state, _profile));
^
be/src/common/status.h:543: expanded from macro 'RETURN_IF_ERROR'
if (UNLIKELY(!_status_.ok())) { \
^
be/src/vec/sink/writer/vhive_table_writer.cpp:154: +3, including nesting penalty of 2, nesting level increased to 3
} catch (doris::Exception& e) {
^
be/src/vec/sink/writer/vhive_table_writer.cpp:161: +2, including nesting penalty of 1, nesting level increased to 2
if (writer_iter == _partitions_to_writers.end()) {
^
be/src/vec/sink/writer/vhive_table_writer.cpp:163: +3, including nesting penalty of 2, nesting level increased to 3
if (_partitions_to_writers.size() + 1 > config::hive_sink_max_open_partitions) {
^
be/src/vec/sink/writer/vhive_table_writer.cpp:167: +3, including nesting penalty of 2, nesting level increased to 3
RETURN_IF_ERROR(create_and_open_writer(partition_name, i, nullptr, 0, writer));
^
be/src/common/status.h:541: expanded from macro 'RETURN_IF_ERROR'
do { \
^
be/src/vec/sink/writer/vhive_table_writer.cpp:167: +4, including nesting penalty of 3, nesting level increased to 4
RETURN_IF_ERROR(create_and_open_writer(partition_name, i, nullptr, 0, writer));
^
be/src/common/status.h:543: expanded from macro 'RETURN_IF_ERROR'
if (UNLIKELY(!_status_.ok())) { \
^
be/src/vec/sink/writer/vhive_table_writer.cpp:168: +1, nesting level increased to 2
} else {
^
be/src/vec/sink/writer/vhive_table_writer.cpp:170: +3, including nesting penalty of 2, nesting level increased to 3
if (writer_iter->second->written_len() > config::hive_sink_max_file_size) {
^
be/src/vec/sink/writer/vhive_table_writer.cpp:179: +4, including nesting penalty of 3, nesting level increased to 4
RETURN_IF_ERROR(create_and_open_writer(partition_name, i, &file_name,
^
be/src/common/status.h:541: expanded from macro 'RETURN_IF_ERROR'
do { \
^
be/src/vec/sink/writer/vhive_table_writer.cpp:179: +5, including nesting penalty of 4, nesting level increased to 5
RETURN_IF_ERROR(create_and_open_writer(partition_name, i, &file_name,
^
be/src/common/status.h:543: expanded from macro 'RETURN_IF_ERROR'
if (UNLIKELY(!_status_.ok())) { \
^
be/src/vec/sink/writer/vhive_table_writer.cpp:181: +1, nesting level increased to 3
} else {
^
be/src/vec/sink/writer/vhive_table_writer.cpp:185: +3, including nesting penalty of 2, nesting level increased to 3
if (writer_pos_iter == writer_positions.end()) {
^
be/src/vec/sink/writer/vhive_table_writer.cpp:189: +1, nesting level increased to 3
} else {
^
@@ -19,6 +19,7 @@ | |||
|
|||
#include <gen_cpp/DataSinks_types.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: 'gen_cpp/DataSinks_types.h' file not found [clang-diagnostic-error]
#include <gen_cpp/DataSinks_types.h>
^
TPC-H: Total hot run time: 39338 ms
|
TPC-DS: Total hot run time: 181257 ms
|
ClickBench: Total hot run time: 29.76 s
|
TeamCity be ut coverage result: |
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
|
c8508dc
to
d46dd70
Compare
run buildall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
@@ -68,114 +81,153 @@ Status VHiveTableWriter::open(RuntimeState* state, RuntimeProfile* profile) { | |||
} | |||
|
|||
Status VHiveTableWriter::write(vectorized::Block& block) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: function 'write' has cognitive complexity of 79 (threshold 50) [readability-function-cognitive-complexity]
Status VHiveTableWriter::write(vectorized::Block& block) {
^
Additional context
be/src/vec/sink/writer/vhive_table_writer.cpp:88: +1, including nesting penalty of 0, nesting level increased to 1
if (_partition_columns_input_index.empty()) {
^
be/src/vec/sink/writer/vhive_table_writer.cpp:93: +2, including nesting penalty of 1, nesting level increased to 2
if (writer_iter == _partitions_to_writers.end()) {
^
be/src/vec/sink/writer/vhive_table_writer.cpp:96: +3, including nesting penalty of 2, nesting level increased to 3
} catch (doris::Exception& e) {
^
be/src/vec/sink/writer/vhive_table_writer.cpp:100: +3, including nesting penalty of 2, nesting level increased to 3
RETURN_IF_ERROR(writer->open(_state, _profile));
^
be/src/common/status.h:541: expanded from macro 'RETURN_IF_ERROR'
do { \
^
be/src/vec/sink/writer/vhive_table_writer.cpp:100: +4, including nesting penalty of 3, nesting level increased to 4
RETURN_IF_ERROR(writer->open(_state, _profile));
^
be/src/common/status.h:543: expanded from macro 'RETURN_IF_ERROR'
if (UNLIKELY(!_status_.ok())) { \
^
be/src/vec/sink/writer/vhive_table_writer.cpp:101: +1, nesting level increased to 2
} else {
^
be/src/vec/sink/writer/vhive_table_writer.cpp:102: +3, including nesting penalty of 2, nesting level increased to 3
if (writer_iter->second->written_len() > config::hive_sink_max_file_size) {
^
be/src/vec/sink/writer/vhive_table_writer.cpp:113: +4, including nesting penalty of 3, nesting level increased to 4
} catch (doris::Exception& e) {
^
be/src/vec/sink/writer/vhive_table_writer.cpp:117: +4, including nesting penalty of 3, nesting level increased to 4
RETURN_IF_ERROR(writer->open(_state, _profile));
^
be/src/common/status.h:541: expanded from macro 'RETURN_IF_ERROR'
do { \
^
be/src/vec/sink/writer/vhive_table_writer.cpp:117: +5, including nesting penalty of 4, nesting level increased to 5
RETURN_IF_ERROR(writer->open(_state, _profile));
^
be/src/common/status.h:543: expanded from macro 'RETURN_IF_ERROR'
if (UNLIKELY(!_status_.ok())) { \
^
be/src/vec/sink/writer/vhive_table_writer.cpp:118: +1, nesting level increased to 3
} else {
^
be/src/vec/sink/writer/vhive_table_writer.cpp:124: +2, including nesting penalty of 1, nesting level increased to 2
RETURN_IF_ERROR(writer->write(block));
^
be/src/common/status.h:541: expanded from macro 'RETURN_IF_ERROR'
do { \
^
be/src/vec/sink/writer/vhive_table_writer.cpp:124: +3, including nesting penalty of 2, nesting level increased to 3
RETURN_IF_ERROR(writer->write(block));
^
be/src/common/status.h:543: expanded from macro 'RETURN_IF_ERROR'
if (UNLIKELY(!_status_.ok())) { \
^
be/src/vec/sink/writer/vhive_table_writer.cpp:130: +1, including nesting penalty of 0, nesting level increased to 1
for (int i = 0; i < block.rows(); ++i) {
^
be/src/vec/sink/writer/vhive_table_writer.cpp:134: +2, including nesting penalty of 1, nesting level increased to 2
} catch (doris::Exception& e) {
^
be/src/vec/sink/writer/vhive_table_writer.cpp:141: nesting level increased to 2
[&](const std::string& partition_name, int position,
^
be/src/vec/sink/writer/vhive_table_writer.cpp:147: +3, including nesting penalty of 2, nesting level increased to 3
RETURN_IF_ERROR(writer->open(_state, _profile));
^
be/src/common/status.h:541: expanded from macro 'RETURN_IF_ERROR'
do { \
^
be/src/vec/sink/writer/vhive_table_writer.cpp:147: +4, including nesting penalty of 3, nesting level increased to 4
RETURN_IF_ERROR(writer->open(_state, _profile));
^
be/src/common/status.h:543: expanded from macro 'RETURN_IF_ERROR'
if (UNLIKELY(!_status_.ok())) { \
^
be/src/vec/sink/writer/vhive_table_writer.cpp:153: +3, including nesting penalty of 2, nesting level increased to 3
} catch (doris::Exception& e) {
^
be/src/vec/sink/writer/vhive_table_writer.cpp:160: +2, including nesting penalty of 1, nesting level increased to 2
if (writer_iter == _partitions_to_writers.end()) {
^
be/src/vec/sink/writer/vhive_table_writer.cpp:162: +3, including nesting penalty of 2, nesting level increased to 3
if (_partitions_to_writers.size() + 1 > config::hive_sink_max_open_partitions) {
^
be/src/vec/sink/writer/vhive_table_writer.cpp:166: +3, including nesting penalty of 2, nesting level increased to 3
RETURN_IF_ERROR(create_and_open_writer(partition_name, i, nullptr, 0, writer));
^
be/src/common/status.h:541: expanded from macro 'RETURN_IF_ERROR'
do { \
^
be/src/vec/sink/writer/vhive_table_writer.cpp:166: +4, including nesting penalty of 3, nesting level increased to 4
RETURN_IF_ERROR(create_and_open_writer(partition_name, i, nullptr, 0, writer));
^
be/src/common/status.h:543: expanded from macro 'RETURN_IF_ERROR'
if (UNLIKELY(!_status_.ok())) { \
^
be/src/vec/sink/writer/vhive_table_writer.cpp:167: +1, nesting level increased to 2
} else {
^
be/src/vec/sink/writer/vhive_table_writer.cpp:169: +3, including nesting penalty of 2, nesting level increased to 3
if (writer_iter->second->written_len() > config::hive_sink_max_file_size) {
^
be/src/vec/sink/writer/vhive_table_writer.cpp:178: +4, including nesting penalty of 3, nesting level increased to 4
RETURN_IF_ERROR(create_and_open_writer(partition_name, i, &file_name,
^
be/src/common/status.h:541: expanded from macro 'RETURN_IF_ERROR'
do { \
^
be/src/vec/sink/writer/vhive_table_writer.cpp:178: +5, including nesting penalty of 4, nesting level increased to 5
RETURN_IF_ERROR(create_and_open_writer(partition_name, i, &file_name,
^
be/src/common/status.h:543: expanded from macro 'RETURN_IF_ERROR'
if (UNLIKELY(!_status_.ok())) { \
^
be/src/vec/sink/writer/vhive_table_writer.cpp:180: +1, nesting level increased to 3
} else {
^
be/src/vec/sink/writer/vhive_table_writer.cpp:184: +3, including nesting penalty of 2, nesting level increased to 3
if (writer_pos_iter == writer_positions.end()) {
^
be/src/vec/sink/writer/vhive_table_writer.cpp:188: +1, nesting level increased to 3
} else {
^
TeamCity be ut coverage result: |
be/src/common/config.cpp
Outdated
@@ -1194,6 +1194,7 @@ DEFINE_mInt32(table_sink_partition_write_max_partition_nums_per_writer, "128"); | |||
|
|||
/** Hive sink configurations **/ | |||
DEFINE_mInt64(hive_sink_max_file_size, "1073741824"); // 1GB | |||
DEFINE_mInt32(hive_sink_max_open_partitions, "10000"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think 10000 is too many? How about 2000?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will use table_sink_partition_write_max_partition_nums_per_writer
d46dd70
to
0237ca7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
@@ -68,114 +81,155 @@ Status VHiveTableWriter::open(RuntimeState* state, RuntimeProfile* profile) { | |||
} | |||
|
|||
Status VHiveTableWriter::write(vectorized::Block& block) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: function 'write' has cognitive complexity of 79 (threshold 50) [readability-function-cognitive-complexity]
Status VHiveTableWriter::write(vectorized::Block& block) {
^
Additional context
be/src/vec/sink/writer/vhive_table_writer.cpp:88: +1, including nesting penalty of 0, nesting level increased to 1
if (_partition_columns_input_index.empty()) {
^
be/src/vec/sink/writer/vhive_table_writer.cpp:93: +2, including nesting penalty of 1, nesting level increased to 2
if (writer_iter == _partitions_to_writers.end()) {
^
be/src/vec/sink/writer/vhive_table_writer.cpp:96: +3, including nesting penalty of 2, nesting level increased to 3
} catch (doris::Exception& e) {
^
be/src/vec/sink/writer/vhive_table_writer.cpp:100: +3, including nesting penalty of 2, nesting level increased to 3
RETURN_IF_ERROR(writer->open(_state, _profile));
^
be/src/common/status.h:541: expanded from macro 'RETURN_IF_ERROR'
do { \
^
be/src/vec/sink/writer/vhive_table_writer.cpp:100: +4, including nesting penalty of 3, nesting level increased to 4
RETURN_IF_ERROR(writer->open(_state, _profile));
^
be/src/common/status.h:543: expanded from macro 'RETURN_IF_ERROR'
if (UNLIKELY(!_status_.ok())) { \
^
be/src/vec/sink/writer/vhive_table_writer.cpp:101: +1, nesting level increased to 2
} else {
^
be/src/vec/sink/writer/vhive_table_writer.cpp:102: +3, including nesting penalty of 2, nesting level increased to 3
if (writer_iter->second->written_len() > config::hive_sink_max_file_size) {
^
be/src/vec/sink/writer/vhive_table_writer.cpp:113: +4, including nesting penalty of 3, nesting level increased to 4
} catch (doris::Exception& e) {
^
be/src/vec/sink/writer/vhive_table_writer.cpp:117: +4, including nesting penalty of 3, nesting level increased to 4
RETURN_IF_ERROR(writer->open(_state, _profile));
^
be/src/common/status.h:541: expanded from macro 'RETURN_IF_ERROR'
do { \
^
be/src/vec/sink/writer/vhive_table_writer.cpp:117: +5, including nesting penalty of 4, nesting level increased to 5
RETURN_IF_ERROR(writer->open(_state, _profile));
^
be/src/common/status.h:543: expanded from macro 'RETURN_IF_ERROR'
if (UNLIKELY(!_status_.ok())) { \
^
be/src/vec/sink/writer/vhive_table_writer.cpp:118: +1, nesting level increased to 3
} else {
^
be/src/vec/sink/writer/vhive_table_writer.cpp:124: +2, including nesting penalty of 1, nesting level increased to 2
RETURN_IF_ERROR(writer->write(block));
^
be/src/common/status.h:541: expanded from macro 'RETURN_IF_ERROR'
do { \
^
be/src/vec/sink/writer/vhive_table_writer.cpp:124: +3, including nesting penalty of 2, nesting level increased to 3
RETURN_IF_ERROR(writer->write(block));
^
be/src/common/status.h:543: expanded from macro 'RETURN_IF_ERROR'
if (UNLIKELY(!_status_.ok())) { \
^
be/src/vec/sink/writer/vhive_table_writer.cpp:130: +1, including nesting penalty of 0, nesting level increased to 1
for (int i = 0; i < block.rows(); ++i) {
^
be/src/vec/sink/writer/vhive_table_writer.cpp:134: +2, including nesting penalty of 1, nesting level increased to 2
} catch (doris::Exception& e) {
^
be/src/vec/sink/writer/vhive_table_writer.cpp:141: nesting level increased to 2
[&](const std::string& partition_name, int position,
^
be/src/vec/sink/writer/vhive_table_writer.cpp:147: +3, including nesting penalty of 2, nesting level increased to 3
RETURN_IF_ERROR(writer->open(_state, _profile));
^
be/src/common/status.h:541: expanded from macro 'RETURN_IF_ERROR'
do { \
^
be/src/vec/sink/writer/vhive_table_writer.cpp:147: +4, including nesting penalty of 3, nesting level increased to 4
RETURN_IF_ERROR(writer->open(_state, _profile));
^
be/src/common/status.h:543: expanded from macro 'RETURN_IF_ERROR'
if (UNLIKELY(!_status_.ok())) { \
^
be/src/vec/sink/writer/vhive_table_writer.cpp:153: +3, including nesting penalty of 2, nesting level increased to 3
} catch (doris::Exception& e) {
^
be/src/vec/sink/writer/vhive_table_writer.cpp:160: +2, including nesting penalty of 1, nesting level increased to 2
if (writer_iter == _partitions_to_writers.end()) {
^
be/src/vec/sink/writer/vhive_table_writer.cpp:162: +3, including nesting penalty of 2, nesting level increased to 3
if (_partitions_to_writers.size() + 1 >
^
be/src/vec/sink/writer/vhive_table_writer.cpp:168: +3, including nesting penalty of 2, nesting level increased to 3
RETURN_IF_ERROR(create_and_open_writer(partition_name, i, nullptr, 0, writer));
^
be/src/common/status.h:541: expanded from macro 'RETURN_IF_ERROR'
do { \
^
be/src/vec/sink/writer/vhive_table_writer.cpp:168: +4, including nesting penalty of 3, nesting level increased to 4
RETURN_IF_ERROR(create_and_open_writer(partition_name, i, nullptr, 0, writer));
^
be/src/common/status.h:543: expanded from macro 'RETURN_IF_ERROR'
if (UNLIKELY(!_status_.ok())) { \
^
be/src/vec/sink/writer/vhive_table_writer.cpp:169: +1, nesting level increased to 2
} else {
^
be/src/vec/sink/writer/vhive_table_writer.cpp:171: +3, including nesting penalty of 2, nesting level increased to 3
if (writer_iter->second->written_len() > config::hive_sink_max_file_size) {
^
be/src/vec/sink/writer/vhive_table_writer.cpp:180: +4, including nesting penalty of 3, nesting level increased to 4
RETURN_IF_ERROR(create_and_open_writer(partition_name, i, &file_name,
^
be/src/common/status.h:541: expanded from macro 'RETURN_IF_ERROR'
do { \
^
be/src/vec/sink/writer/vhive_table_writer.cpp:180: +5, including nesting penalty of 4, nesting level increased to 5
RETURN_IF_ERROR(create_and_open_writer(partition_name, i, &file_name,
^
be/src/common/status.h:543: expanded from macro 'RETURN_IF_ERROR'
if (UNLIKELY(!_status_.ok())) { \
^
be/src/vec/sink/writer/vhive_table_writer.cpp:182: +1, nesting level increased to 3
} else {
^
be/src/vec/sink/writer/vhive_table_writer.cpp:186: +3, including nesting penalty of 2, nesting level increased to 3
if (writer_pos_iter == writer_positions.end()) {
^
be/src/vec/sink/writer/vhive_table_writer.cpp:190: +1, nesting level increased to 3
} else {
^
run buildall |
hive_sink_max_open_partitions
.table_sink_partition_write_max_partition_nums_per_writer
. .
table_sink_partition_write_max_partition_nums_per_writer
. .table_sink_partition_write_max_partition_nums_per_writer
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
TeamCity be ut coverage result: |
… change output file names (apache#33245) Issue Number: apache#31442 - Add hive-writer runtime profiles. - Change output file names to `${query_id}${uuid}-${index}.${compression}.${format}`. e.g. `"d8735c6fa444a6d-acd392981e510c2b_34fbdcbb-b2e1-4f2c-b68c-a384238954a9-0.snappy.parquet"`. For the same partition writer, when the file size exceeds `hive_sink_max_file_size`, the currently written file will be closed and a new file will be generated, in which ${index} in the new file name will be incremented, while the rest will be the same .
… change output file names (#33245) Issue Number: #31442 - Add hive-writer runtime profiles. - Change output file names to `${query_id}${uuid}-${index}.${compression}.${format}`. e.g. `"d8735c6fa444a6d-acd392981e510c2b_34fbdcbb-b2e1-4f2c-b68c-a384238954a9-0.snappy.parquet"`. For the same partition writer, when the file size exceeds `hive_sink_max_file_size`, the currently written file will be closed and a new file will be generated, in which ${index} in the new file name will be incremented, while the rest will be the same .
Proposed changes
Issue Number: #31442
${query_id}${uuid}-${index}.${compression}.${format}
. e.g."d8735c6fa444a6d-acd392981e510c2b_34fbdcbb-b2e1-4f2c-b68c-a384238954a9-0.snappy.parquet"
. For the same partition writer, when the file size exceedshive_sink_max_file_size
, the currently written file will be closed and a new file will be generated, in which ${index} in the new file name will be incremented, while the rest will be the same .table_sink_partition_write_max_partition_nums_per_writer
to control max open partitions in hive sink.Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...