Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](UT) Fix incorrect command for cloud run_all_tests.sh #33274

Merged
merged 2 commits into from
Apr 6, 2024

Conversation

gavinchou
Copy link
Collaborator

llvm-profdata merge -o doesn't need a quoted param.

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@gavinchou
Copy link
Collaborator Author

run buildall

Copy link
Contributor

github-actions bot commented Apr 5, 2024

sh-checker report

To get the full details, please check in the job output.

shellcheck errors

'shellcheck ' returned error 1 finding the following syntactical issues:

----------

In cloud/script/run_all_tests.sh line 117:
    llvm-profdata merge -o ${profdata} ${profraw}
                           ^---------^ SC2248 (style): Prefer double quoting even when variables don't contain special characters.
                                       ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
    llvm-profdata merge -o "${profdata}" "${profraw}"


In cloud/script/run_all_tests.sh line 120:
        -instr-profile=${profdata} \
                       ^---------^ SC2248 (style): Prefer double quoting even when variables don't contain special characters.

Did you mean: 
        -instr-profile="${profdata}" \


In cloud/script/run_all_tests.sh line 121:
        ${binary_objects_options[*]}
        ^--------------------------^ SC2048 (warning): Use "${array[@]}" (with quotes) to prevent whitespace problems.
        ^--------------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
        "${binary_objects_options[*]}"

For more information:
  https://www.shellcheck.net/wiki/SC2048 -- Use "${array[@]}" (with quotes) t...
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
  https://www.shellcheck.net/wiki/SC2248 -- Prefer double quoting even when v...
----------

You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
  # shellcheck disable=NNNN
above the line that contains the issue, where NNNN is the error code;
3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.



shfmt errors
'shfmt ' found no issues.

Copy link
Contributor

github-actions bot commented Apr 5, 2024

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

github-actions bot commented Apr 5, 2024

sh-checker report

To get the full details, please check in the job output.

shellcheck errors

'shellcheck ' returned error 1 finding the following syntactical issues:

----------

In cloud/script/run_all_tests.sh line 113:
    for object in $(echo "${binary_objects}"); do
                  ^-------------------------^ SC2116 (style): Useless echo? Instead of 'cmd $(echo foo)', just use 'cmd foo'.


In cloud/script/run_all_tests.sh line 116:
    profraw=$(\ls ./report/*.profraw | tr '\n' ' ')
               ^-------------------^ SC2012 (info): Use find instead of ls to better handle non-alphanumeric filenames.

For more information:
  https://www.shellcheck.net/wiki/SC2012 -- Use find instead of ls to better ...
  https://www.shellcheck.net/wiki/SC2116 -- Useless echo? Instead of 'cmd $(e...
----------

You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
  # shellcheck disable=NNNN
above the line that contains the issue, where NNNN is the error code;
3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.



shfmt errors
'shfmt ' found no issues.

Copy link
Contributor

github-actions bot commented Apr 5, 2024

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

github-actions bot commented Apr 5, 2024

sh-checker report

To get the full details, please check in the job output.

shellcheck errors

'shellcheck ' returned error 1 finding the following syntactical issues:

----------

In cloud/script/run_all_tests.sh line 123:
    llvm-profdata merge -o ${profdata} ${profraw}
                           ^---------^ SC2248 (style): Prefer double quoting even when variables don't contain special characters.

Did you mean: 
    llvm-profdata merge -o "${profdata}" ${profraw}


In cloud/script/run_all_tests.sh line 126:
        -instr-profile=${profdata} \
                       ^---------^ SC2248 (style): Prefer double quoting even when variables don't contain special characters.

Did you mean: 
        -instr-profile="${profdata}" \

For more information:
  https://www.shellcheck.net/wiki/SC2248 -- Prefer double quoting even when v...
----------

You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
  # shellcheck disable=NNNN
above the line that contains the issue, where NNNN is the error code;
3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.



shfmt errors

'shfmt ' returned error 1 finding the following formatting issues:

----------
--- cloud/script/run_all_tests.sh.orig
+++ cloud/script/run_all_tests.sh
@@ -104,7 +104,6 @@
 
 export LD_LIBRARY_PATH="${DORIS_JAVA_HOME}/lib/server:${LD_LIBRARY_PATH}"
 
-
 # disable some STUPID shell-check rules for this function
 # shellcheck disable=SC2048
 # shellcheck disable=SC2068
----------

You can reformat the above files to meet shfmt's requirements by typing:

  shfmt  -w filename


Copy link
Contributor

github-actions bot commented Apr 5, 2024

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

github-actions bot commented Apr 5, 2024

sh-checker report

To get the full details, please check in the job output.

shellcheck errors
'shellcheck ' found no issues.

shfmt errors

'shfmt ' returned error 1 finding the following formatting issues:

----------
--- cloud/script/run_all_tests.sh.orig
+++ cloud/script/run_all_tests.sh
@@ -104,7 +104,6 @@
 
 export LD_LIBRARY_PATH="${DORIS_JAVA_HOME}/lib/server:${LD_LIBRARY_PATH}"
 
-
 # disable some STUPID shell-check rules for this function
 # shellcheck disable=SC2048
 # shellcheck disable=SC2068
----------

You can reformat the above files to meet shfmt's requirements by typing:

  shfmt  -w filename


Copy link
Contributor

github-actions bot commented Apr 5, 2024

sh-checker report

To get the full details, please check in the job output.

shellcheck errors
'shellcheck ' found no issues.

shfmt errors

'shfmt ' returned error 1 finding the following formatting issues:

----------
--- cloud/script/run_all_tests.sh.orig
+++ cloud/script/run_all_tests.sh
@@ -104,7 +104,6 @@
 
 export LD_LIBRARY_PATH="${DORIS_JAVA_HOME}/lib/server:${LD_LIBRARY_PATH}"
 
-
 # disable some STUPID shell-check rules for this function
 # shellcheck disable=SC2048,SC2068,SC2086,SC2155,SC2248
 # report converage for unittest
----------

You can reformat the above files to meet shfmt's requirements by typing:

  shfmt  -w filename


Copy link
Contributor

github-actions bot commented Apr 5, 2024

clang-tidy review says "All clean, LGTM! 👍"

2 similar comments
Copy link
Contributor

github-actions bot commented Apr 5, 2024

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

github-actions bot commented Apr 5, 2024

clang-tidy review says "All clean, LGTM! 👍"

@gavinchou
Copy link
Collaborator Author

run buildall

dataroaring
dataroaring previously approved these changes Apr 6, 2024
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

github-actions bot commented Apr 6, 2024

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Apr 6, 2024
Copy link
Contributor

github-actions bot commented Apr 6, 2024

PR approved by anyone and no changes requested.

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Apr 6, 2024
Copy link
Contributor

github-actions bot commented Apr 6, 2024

clang-tidy review says "All clean, LGTM! 👍"

@gavinchou
Copy link
Collaborator Author

run buildall

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 6, 2024
Copy link
Contributor

github-actions bot commented Apr 6, 2024

PR approved by at least one committer and no changes requested.

@dataroaring dataroaring merged commit a8596ec into apache:master Apr 6, 2024
27 of 28 checks passed
seawinde pushed a commit to seawinde/doris that referenced this pull request Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants