[Bug](array) fix array column core dump in get_shrinked_column as not check type #33295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
HappenLee
reviewed
Apr 7, 2024
yiguolei
reviewed
Apr 7, 2024
|
run buildall |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| bool is_variable_length() const override { return nested_column->is_variable_length(); } | ||
|
|
There was a problem hiding this comment.
warning: method 'get_family_name' can be made static [readability-convert-member-functions-to-static]
Suggested change
| static const char* get_family_name() override { return "Nullable"; } |
| @@ -120,6 +120,7 @@ class ColumnString final : public COWHelper<IColumn, ColumnString> { | |||
| MutableColumnPtr clone_resized(size_t to_size) const override; | |||
|
|
|||
| MutableColumnPtr get_shrinked_column() override; | |||
| bool could_shrinked_column() override { return true; } | |||
There was a problem hiding this comment.
warning: method 'could_shrinked_column' can be made static [readability-convert-member-functions-to-static]
Suggested change
| bool could_shrinked_column() override { return true; } | |
| static bool could_shrinked_column() override { return true; } |
| @@ -295,13 +295,22 @@ ColumnPtr ColumnStruct::replicate(const Offsets& offsets) const { | |||
| return ColumnStruct::create(new_columns); | |||
| } | |||
|
|
|||
| bool ColumnStruct::could_shrinked_column() { | |||
There was a problem hiding this comment.
warning: method 'could_shrinked_column' can be made static [readability-convert-member-functions-to-static]
be/src/vec/columns/column_struct.h:158:
- bool could_shrinked_column() override;
+ static bool could_shrinked_column() override;
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
TPC-H: Total hot run time: 38915 ms |
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 180883 ms |
ClickBench: Total hot run time: 30.3 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
yiguolei
pushed a commit
that referenced
this pull request
Apr 7, 2024
… check type (#33295) * [Bug](array) fix array column core dump in get_shrinked_column as not check type * add function could_shrinked_column
seawinde
pushed a commit
to seawinde/doris
that referenced
this pull request
Apr 10, 2024
… check type (apache#33295) * [Bug](array) fix array column core dump in get_shrinked_column as not check type * add function could_shrinked_column
zhangstar333
added a commit
to zhangstar333/incubator-doris
that referenced
this pull request
Apr 11, 2024
… check type (apache#33295) * [Bug](array) fix array column core dump in get_shrinked_column as not check type * add function could_shrinked_column
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_shrinked_column() function should only call by string type.
so should check column type.
Proposed changes
Issue Number: close #xxx
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...