Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](compress) data decompress failed while max_len equals 8M #33456

Merged
merged 3 commits into from
Apr 10, 2024
Merged

[fix](compress) data decompress failed while max_len equals 8M #33456

merged 3 commits into from
Apr 10, 2024

Conversation

cambyzju
Copy link
Contributor

@cambyzju cambyzju commented Apr 10, 2024 •
edited

Proposed changes

issue: #33455

come from pr: #12573

While max_len == MAX_COMPRESSION_BUFFER_FOR_REUSE, we reuse context buffer, but do not copy them to the final output buf, make the data corrupted.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@cambyzju cambyzju changed the title [fix](compress) data decompress failed while max_len equals MAX_COMPRESSION_BUFFER_SIZE_FOR_REUSE [fix](compress) data decompress failed while max_len equals 8M Apr 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@lide-reed lide-reed self-requested a review April 10, 2024 04:03
lide-reed
lide-reed previously approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@lide-reed lide-reed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Apr 10, 2024
@cambyzju
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 35.64% (8907/24990)
Line Coverage: 27.37% (73162/267260)
Region Coverage: 26.54% (37796/142437)
Branch Coverage: 23.34% (19258/82512)
Coverage Report: http://coverage.selectdb-in.cc/coverage/c94b860cfaf1b73343f243607dc76686aa4c84be_c94b860cfaf1b73343f243607dc76686aa4c84be/report/index.html

xy720
xy720 approved these changes Apr 10, 2024
View reviewed changes
Copy link
Member

@xy720 xy720 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@yiguolei yiguolei merged commit 1fea40a into apache:master Apr 10, 2024
26 of 30 checks passed
yiguolei pushed a commit that referenced this pull request Apr 11, 2024
@cambyzju @Doris-Extras
[fix](compress) data decompress failed while max_len equals 8M (#33456)
3e7b253 
* fix data decompress failed while max_len equals MAX_COMPRESSION_BUFFER_SIZE_FOR_REUSE

* update code format error
cambyzju added a commit to cambyzju/incubator-doris that referenced this pull request Apr 11, 2024
@cambyzju
[fix](compress) data decompress failed while max_len equals 8M (apach…
2e986aa 
…e#33456)

* fix data decompress failed while max_len equals MAX_COMPRESSION_BUFFER_SIZE_FOR_REUSE

* update code format error
@cambyzju cambyzju mentioned this pull request Apr 11, 2024
Merged
cambyzju added a commit to cambyzju/incubator-doris that referenced this pull request Apr 11, 2024
@cambyzju
[fix](compress) data decompress failed while max_len equals 8M (apach…
abd2760 
…e#33456)

* fix data decompress failed while max_len equals MAX_COMPRESSION_BUFFER_SIZE_FOR_REUSE

* update code format error
@cambyzju cambyzju mentioned this pull request Apr 11, 2024
Merged
yiguolei pushed a commit that referenced this pull request Apr 11, 2024
@cambyzju
[fix](compress) data decompress failed while max_len equals 8M (#33456)…
1aced46 
… (#33513)

* fix data decompress failed while max_len equals MAX_COMPRESSION_BUFFER_SIZE_FOR_REUSE

* update code format error
yiguolei pushed a commit that referenced this pull request Apr 11, 2024
@cambyzju
[fix](compress) data decompress failed while max_len equals 8M (#33456)…
bd54a04 
… (#33514)

* fix data decompress failed while max_len equals MAX_COMPRESSION_BUFFER_SIZE_FOR_REUSE

* update code format error
dataroaring pushed a commit that referenced this pull request Apr 24, 2024
@cambyzju @dataroaring
[fix](compress) data decompress failed while max_len equals 8M (#33456)
62fda71 
* fix data decompress failed while max_len equals MAX_COMPRESSION_BUFFER_SIZE_FOR_REUSE

* update code format error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacktengg jacktengg jacktengg approved these changes

@xy720 xy720 xy720 approved these changes

@lide-reed lide-reed lide-reed left review comments

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/1.2.9 dev/2.0.9-merged dev/2.1.x reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@cambyzju @doris-robot @lide-reed @jacktengg @xy720 @yiguolei @wm1581066