Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](shutdown) Fix use-after-free during graceful shutdown #33457

Merged
merged 1 commit into from
Apr 16, 2024
Merged

[fix](shutdown) Fix use-after-free during graceful shutdown #33457

merged 1 commit into from
Apr 16, 2024

Conversation

platoneko
Copy link
Contributor

Proposed changes

Fix use-after-free during graceful shutdown

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@platoneko
Copy link
Contributor Author

run buildall

@platoneko platoneko closed this Apr 10, 2024
@platoneko platoneko reopened this Apr 10, 2024
@platoneko
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

2 similar comments
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@dataroaring
Copy link
Contributor

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 35.58% (8903/25020)
Line Coverage: 27.31% (73119/267774)
Region Coverage: 26.41% (37807/143134)
Branch Coverage: 23.20% (19273/83080)
Coverage Report: http://coverage.selectdb-in.cc/coverage/335856e4effcfb98e91ac844b4477a217b4b06b3_335856e4effcfb98e91ac844b4477a217b4b06b3/report/index.html

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

dataroaring
dataroaring approved these changes Apr 13, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@platoneko platoneko merged commit 6d441ba into apache:master Apr 16, 2024
25 of 29 checks passed
dataroaring pushed a commit that referenced this pull request Apr 17, 2024
@platoneko @dataroaring
Fix use-after-free during graceful shutdown (#33457)
ef67bef
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gavinchou gavinchou gavinchou approved these changes

@dataroaring dataroaring dataroaring approved these changes

Assignees
No one assigned
Labels
2.1.0-conflict approved Indicates a PR has been approved by one committer. dev/3.0.0-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@platoneko @doris-robot @dataroaring @gavinchou @xiaokang @yiguolei