-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix](move-memtable) avoid raw pointer to RuntimeState in DeltaWriterV2 #33682
Conversation
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
run buildall |
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 38631 ms
|
TPC-DS: Total hot run time: 184010 ms
|
ClickBench: Total hot run time: 29.52 s
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
|
run buildall |
clang-tidy review says "All clean, LGTM! 👍" |
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 38316 ms
|
TPC-DS: Total hot run time: 184308 ms
|
ClickBench: Total hot run time: 30.75 s
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
|
run buildall |
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 39493 ms
|
TPC-DS: Total hot run time: 184014 ms
|
ClickBench: Total hot run time: 30.73 s
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Memtable thread will access many other members in runtime state. We should find why runtime state is deconstructed.
Proposed changes
Avoid using raw pointer to RuntimeState in DeltaWriterV2.
Which was introduced in #29280 and #30610.
To fix the following coredump:
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...