Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](nereids)InSubquery's withChildren method lost typeCoercionExpr #33694

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

starocean999
Copy link
Contributor

@starocean999 starocean999 commented Apr 16, 2024

Proposed changes

pick from master #33692

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@starocean999
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 49773 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit d4a9e6864da93de8c999b61dbc398b32a961236e, data reload: false

------ Round 1 ----------------------------------
q1	17842	4377	4292	4292
q2	2057	146	144	144
q3	10442	1900	1909	1900
q4	10373	1238	1280	1238
q5	8305	3975	3937	3937
q6	229	123	122	122
q7	2053	1577	1614	1577
q8	9278	2700	2703	2700
q9	10652	10481	10377	10377
q10	8625	3521	3529	3521
q11	418	238	245	238
q12	457	292	300	292
q13	18340	3957	3997	3957
q14	355	318	319	318
q15	498	464	449	449
q16	710	607	615	607
q17	1127	949	958	949
q18	7383	7014	6918	6918
q19	1658	1525	1493	1493
q20	533	332	305	305
q21	4477	4147	4042	4042
q22	506	397	399	397
Total cold run time: 116318 ms
Total hot run time: 49773 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4305	4318	4261	4261
q2	317	219	218	218
q3	4128	4144	4126	4126
q4	2724	2734	2737	2734
q5	7315	7169	7215	7169
q6	231	117	115	115
q7	3268	2846	2868	2846
q8	4406	4461	4459	4459
q9	17054	16968	16911	16911
q10	4232	4297	4260	4260
q11	777	678	693	678
q12	1021	839	861	839
q13	9207	3747	3779	3747
q14	457	431	428	428
q15	499	461	462	461
q16	752	694	694	694
q17	3806	3853	3820	3820
q18	8773	8820	8808	8808
q19	1695	1724	1636	1636
q20	2434	2222	2191	2191
q21	8827	8816	8853	8816
q22	1084	1024	1022	1022
Total cold run time: 87312 ms
Total hot run time: 80239 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 199914 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit d4a9e6864da93de8c999b61dbc398b32a961236e, data reload: false

query1	917	388	380	380
query2	6517	2322	1919	1919
query3	6916	201	195	195
query4	20954	17889	17968	17889
query5	19725	6553	6426	6426
query6	396	206	237	206
query7	5183	306	301	301
query8	237	282	214	214
query9	3106	2670	2616	2616
query10	439	289	315	289
query11	11227	10806	10647	10647
query12	125	77	72	72
query13	5593	683	625	625
query14	18852	13582	13240	13240
query15	358	224	232	224
query16	6419	275	256	256
query17	1339	1514	873	873
query18	2282	399	394	394
query19	200	138	145	138
query20	75	78	72	72
query21	183	96	87	87
query22	5125	4846	4984	4846
query23	32439	31911	31929	31911
query24	6736	6579	6452	6452
query25	529	421	415	415
query26	519	159	158	158
query27	1758	295	291	291
query28	6070	2279	2243	2243
query29	2894	2885	2773	2773
query30	239	157	157	157
query31	913	703	723	703
query32	63	59	55	55
query33	393	241	242	241
query34	847	463	491	463
query35	1095	887	909	887
query36	1368	1125	1170	1125
query37	97	62	60	60
query38	3067	2929	2905	2905
query39	1358	1310	1311	1310
query40	209	91	97	91
query41	35	35	31	31
query42	86	83	79	79
query43	607	551	606	551
query44	1127	727	723	723
query45	239	229	227	227
query46	1224	976	970	970
query47	1815	1835	1623	1623
query48	973	675	660	660
query49	621	364	353	353
query50	857	630	597	597
query51	4801	4669	4591	4591
query52	93	80	89	80
query53	432	330	305	305
query54	2660	2470	2455	2455
query55	84	78	75	75
query56	197	203	194	194
query57	1140	1076	1098	1076
query58	219	187	201	187
query59	3450	3196	3084	3084
query60	208	189	188	188
query61	85	83	86	83
query62	880	482	531	482
query63	476	327	331	327
query64	2507	1497	1354	1354
query65	3640	3541	3518	3518
query66	764	384	357	357
query67	17450	15319	15414	15319
query68	8369	656	684	656
query69	568	322	341	322
query70	1598	1360	1449	1360
query71	410	295	311	295
query72	6403	3430	3398	3398
query73	729	324	329	324
query74	6264	5913	5836	5836
query75	4536	3689	3721	3689
query76	4716	1166	1174	1166
query77	613	249	251	249
query78	12564	12094	11438	11438
query79	10560	647	637	637
query80	2056	389	382	382
query81	503	234	227	227
query82	1560	96	93	93
query83	160	133	137	133
query84	255	67	68	67
query85	1298	281	275	275
query86	334	287	287	287
query87	3195	3023	3010	3010
query88	5113	2354	2355	2354
query89	483	314	283	283
query90	1752	206	205	205
query91	152	113	111	111
query92	58	55	55	55
query93	6951	631	552	552
query94	726	203	197	197
query95	1094	1079	1057	1057
query96	638	337	327	327
query97	6506	6279	6316	6279
query98	190	174	173	173
query99	3107	839	889	839
Total cold run time: 316893 ms
Total hot run time: 199914 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.18 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit d4a9e6864da93de8c999b61dbc398b32a961236e, data reload: false

query1	0.02	0.02	0.02
query2	0.07	0.02	0.02
query3	0.24	0.04	0.04
query4	1.80	0.06	0.06
query5	0.52	0.52	0.52
query6	1.24	0.61	0.62
query7	0.02	0.02	0.01
query8	0.03	0.02	0.02
query9	0.52	0.51	0.48
query10	0.54	0.52	0.54
query11	0.12	0.09	0.09
query12	0.11	0.09	0.09
query13	0.62	0.63	0.61
query14	0.78	0.79	0.78
query15	0.79	0.76	0.75
query16	0.36	0.37	0.37
query17	0.96	1.04	0.97
query18	0.23	0.26	0.25
query19	1.91	1.87	1.85
query20	0.02	0.01	0.01
query21	15.49	0.56	0.54
query22	2.40	2.35	1.56
query23	17.14	0.99	0.92
query24	7.12	1.88	0.53
query25	0.39	0.07	0.05
query26	0.87	0.17	0.15
query27	0.05	0.04	0.03
query28	5.65	0.77	0.75
query29	12.67	2.32	2.37
query30	0.57	0.52	0.51
query31	2.80	0.39	0.37
query32	3.41	0.49	0.49
query33	3.07	3.04	3.03
query34	15.25	4.80	4.79
query35	4.87	4.84	4.82
query36	1.05	1.00	1.05
query37	0.06	0.04	0.04
query38	0.03	0.02	0.02
query39	0.02	0.02	0.02
query40	0.15	0.14	0.14
query41	0.08	0.02	0.01
query42	0.02	0.01	0.01
query43	0.02	0.01	0.02
Total cold run time: 104.08 s
Total hot run time: 30.18 s

@doris-robot
Copy link

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit d4a9e6864da93de8c999b61dbc398b32a961236e with default session variables
Stream load json:         20 seconds loaded 2358488459 Bytes, about 112 MB/s
Stream load orc:          58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet:      32 seconds loaded 861443392 Bytes, about 25 MB/s
Insert into select:       20.7 seconds inserted 10000000 Rows, about 483K ops/s

@morrySnow morrySnow merged commit 6758dfe into apache:branch-2.0 Apr 16, 2024
26 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants