(cloud-merge) Check the cache config size whether is larger than disk_resource_limit_mode_percent #34137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -80,10 +80,13 @@ Status FileCacheFactory::create_file_cache(const std::string& cache_base_path, | |||
| LOG_ERROR("").tag("file cache path", cache_base_path).tag("error", strerror(errno)); | |||
| return Status::IOError("{} statfs error {}", cache_base_path, strerror(errno)); | |||
| } | |||
| size_t disk_total_size = static_cast<size_t>(stat.f_blocks) * static_cast<size_t>(stat.f_bsize); | |||
| size_t disk_total_size = static_cast<size_t>(static_cast<size_t>(stat.f_blocks) * static_cast<size_t>(stat.f_bsize) | |||
There was a problem hiding this comment.
warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
Suggested change
| size_t disk_total_size = static_cast<size_t>(static_cast<size_t>(stat.f_blocks) * static_cast<size_t>(stat.f_bsize) | |
| auto disk_total_size = static_cast<size_t>(static_cast<size_t>(stat.f_blocks) * static_cast<size_t>(stat.f_bsize) |
|
run buildall |
| @@ -80,10 +80,15 @@ Status FileCacheFactory::create_file_cache(const std::string& cache_base_path, | |||
| LOG_ERROR("").tag("file cache path", cache_base_path).tag("error", strerror(errno)); | |||
| return Status::IOError("{} statfs error {}", cache_base_path, strerror(errno)); | |||
| } | |||
| size_t disk_total_size = static_cast<size_t>(stat.f_blocks) * static_cast<size_t>(stat.f_bsize); | |||
| size_t disk_total_size = static_cast<size_t>( | |||
There was a problem hiding this comment.
warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
Suggested change
| size_t disk_total_size = static_cast<size_t>( | |
| auto disk_total_size = static_cast<size_t>( |
|
run buildall |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 40691 ms |
TPC-DS: Total hot run time: 187381 ms |
gavinchou
reviewed
Apr 26, 2024
gavinchou
reviewed
Apr 26, 2024
|
run buildall |
| if (disk_total_size < file_cache_settings.capacity) { | ||
| file_cache_settings = get_file_cache_settings(size_t(disk_total_size * 0.9), | ||
| file_cache_settings.max_query_cache_size); | ||
| size_t disk_capacity = static_cast<size_t>( |
There was a problem hiding this comment.
warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
Suggested change
| size_t disk_capacity = static_cast<size_t>( | |
| auto disk_capacity = static_cast<size_t>( |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 41044 ms |
TPC-DS: Total hot run time: 185957 ms |
gavinchou
approved these changes
Apr 28, 2024
|
PR approved by anyone and no changes requested. |
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
M1saka2003
pushed a commit
to M1saka2003/doris
that referenced
this pull request
May 14, 2024
…_resource_limit_mode_percent (apache#34137)
M1saka2003
pushed a commit
to M1saka2003/doris
that referenced
this pull request
May 24, 2024
…_resource_limit_mode_percent (apache#34137)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
2978
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...