[fix](short circurt) fix return default value issue #34186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
clang-tidy review says "All clean, LGTM! 👍" |
cjj2010
reviewed
Apr 26, 2024
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 41108 ms |
TPC-DS: Total hot run time: 186957 ms |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 40682 ms |
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 187298 ms |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
eldenmoon
reviewed
May 10, 2024
be/src/vec/jsonb/serialize.cpp
Outdated
| @@ -107,7 +107,7 @@ void JsonbSerializeUtil::jsonb_to_block(const DataTypeSerDeSPtrs& serdes, const | |||
| MutableColumnPtr col = column_type_name.column->assume_mutable(); | |||
| if (col->size() < num_rows + 1) { | |||
| DCHECK(col->size() == num_rows); | |||
| if (default_values[i].empty()) { | |||
| if (default_values[i].empty() || col->empty()) { | |||
There was a problem hiding this comment.
maybe it's wrong, the col always empty for the start, so when default_values[i] is not emtpy, it may result incorrect value
felixwluo
dismissed stale reviews from eldenmoon, cambyzju, and dataroaring
via
796ccaa
|
clang-tidy review says "All clean, LGTM! 👍" |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 41644 ms |
TPC-DS: Total hot run time: 169192 ms |
ClickBench: Total hot run time: 30.22 s |
|
TeamCity be ut coverage result: |
felixwluo
force-pushed
the
fix_short_circurt
branch
from
5f58566
to
8c54f19
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 40640 ms |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 39911 ms |
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 172933 ms |
ClickBench: Total hot run time: 31.07 s |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
yiguolei
pushed a commit
that referenced
this pull request
May 29, 2024
dataroaring
pushed a commit
that referenced
this pull request
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #34056
problem
When using short circurt for point-checking, if a field in the table constructor clause has a default value and a NULL value is written later, the query returns the default value instead of the NULL valuerecurrence
The query result is 1970-01-01 00:00:00.111
3、after restoration
Query returns NULL after repairFurther comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...