Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP](test) remove enable_nereids_planner in regression cases (part 1) #34417

Merged
merged 1 commit into from
May 6, 2024

Conversation

morrySnow
Copy link
Contributor

@morrySnow morrySnow commented May 6, 2024

we need to remove all enable_nereids_planner statement in regression test.
since there are too many cases include it, we need use multiple pr to fix all cases.
this is the first pr.

this PR mode some result of regression test, because:

  1. result of create_view_star_except_and_cast_to_sql generated by legacy planner is wrong
  2. result of test_nullable_functions generated by legacy planner is wrong
  3. result of test_array_functions generated by legacy planner is wrong

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@morrySnow
Copy link
Contributor Author

run buildall

we need to remove all enable_nereids_planner statement in regression test.
since there are too many cases include it, we need use multiple pr to fix all cases.
this is the first pr.
@morrySnow
Copy link
Contributor Author

run buildall

@morrySnow
Copy link
Contributor Author

run cloud_p1

Copy link
Collaborator

@shuke987 shuke987 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

github-actions bot commented May 6, 2024

PR approved by anyone and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 6, 2024
Copy link
Contributor

github-actions bot commented May 6, 2024

PR approved by at least one committer and no changes requested.

@morrySnow morrySnow merged commit 43cff66 into apache:master May 6, 2024
27 of 29 checks passed
@morrySnow morrySnow deleted the remove_some_nereids_set branch May 6, 2024 12:11
morrySnow added a commit to morrySnow/incubator-doris that referenced this pull request May 8, 2024
morrySnow added a commit that referenced this pull request May 9, 2024
yiguolei pushed a commit that referenced this pull request May 10, 2024
ByteYue pushed a commit to ByteYue/doris that referenced this pull request May 15, 2024
apache#34417)

we need to remove all enable_nereids_planner statement in regression test.
since there are too many cases include it, we need use multiple pr to fix all cases.
this is the first pr.

this PR mode some result of regression test, because:

1. result of create_view_star_except_and_cast_to_sql generated by legacy planner is wrong
2. result of test_nullable_functions generated by legacy planner is wrong
3. result of test_array_functions generated by legacy planner is wrong
ByteYue pushed a commit to ByteYue/doris that referenced this pull request May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants