-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix](user manager) Add rwlock for userManager #34699
Conversation
fix ``` 2024-05-10 14:33:55,005 mysql-nio-pool-67 ERROR An exception occurred processing Appender Sys java.util.ConcurrentModificationException at java.base/java.util.HashMap$HashIterator.nextNode(HashMap.java:1597) at java.base/java.util.HashMap$EntryIterator.next(HashMap.java:1630) at java.base/java.util.HashMap$EntryIterator.next(HashMap.java:1628) at org.apache.logging.log4j.message.ParameterFormatter.appendMap(ParameterFormatter.java:581) at org.apache.logging.log4j.message.ParameterFormatter.appendPotentiallyRecursiveValue(ParameterFormatter.java:512) at org.apache.logging.log4j.message.ParameterFormatter.recursiveDeepToString(ParameterFormatter.java:477) at org.apache.logging.log4j.message.ParameterFormatter.recursiveDeepToString(ParameterFormatter.java:448) at org.apache.logging.log4j.message.ParameterFormatter.formatMessage2(ParameterFormatter.java:191) at org.apache.logging.log4j.message.ParameterizedMessage.formatTo(ParameterizedMessage.java:227) at org.apache.logging.log4j.core.pattern.MessagePatternConverter$SimpleMessagePatternConverter.format(MessagePatternConverter.java:121) at org.apache.logging.log4j.core.layout.PatternLayout$NoFormatPatternSerializer.toSerializable(PatternLayout.java:342) at org.apache.logging.log4j.core.layout.PatternLayout.toText(PatternLayout.java:240) at org.apache.logging.log4j.core.layout.PatternLayout.encode(PatternLayout.java:225) at org.apache.logging.log4j.core.layout.PatternLayout.encode(PatternLayout.java:59) at org.apache.logging.log4j.core.appender.AbstractOutputStreamAppender.directEncodeEvent(AbstractOutputStreamAppender.java:215) at org.apache.logging.log4j.core.appender.AbstractOutputStreamAppender.tryAppend(AbstractOutputStreamAppender.java:208) at org.apache.logging.log4j.core.appender.AbstractOutputStreamAppender.append(AbstractOutputStreamAppender.java:199) at org.apache.logging.log4j.core.appender.RollingFileAppender.append(RollingFileAppender.java:301) at org.apache.logging.log4j.core.config.AppenderControl.tryCallAppender(AppenderControl.java:161) at org.apache.logging.log4j.core.config.AppenderControl.callAppender0(AppenderControl.java:134) at org.apache.logging.log4j.core.config.AppenderControl.callAppenderPreventRecursion(AppenderControl.java:125) at org.apache.logging.log4j.core.config.AppenderControl.callAppender(AppenderControl.java:89) at org.apache.logging.log4j.core.config.LoggerConfig.callAppenders(LoggerConfig.java:675) at org.apache.logging.log4j.core.config.LoggerConfig.processLogEvent(LoggerConfig.java:633) at org.apache.logging.log4j.core.config.LoggerConfig.log(LoggerConfig.java:616) at org.apache.logging.log4j.core.config.LoggerConfig.log(LoggerConfig.java:552) at org.apache.logging.log4j.core.config.AwaitCompletionReliabilityStrategy.log(AwaitCompletionReliabilityStrategy.java:82) at org.apache.logging.log4j.core.Logger.log(Logger.java:161) at org.apache.logging.log4j.spi.AbstractLogger.tryLogMessage(AbstractLogger.java:2205) at org.apache.logging.log4j.spi.AbstractLogger.logMessageTrackRecursion(AbstractLogger.java:2159) at org.apache.logging.log4j.spi.AbstractLogger.logMessageSafely(AbstractLogger.java:2142) at org.apache.logging.log4j.spi.AbstractLogger.logMessage(AbstractLogger.java:2040) at org.apache.logging.log4j.spi.AbstractLogger.logIfEnabled(AbstractLogger.java:1907) at org.apache.logging.log4j.spi.AbstractLogger.warn(AbstractLogger.java:2789) at org.apache.doris.mysql.privilege.UserManager.getUserId(UserManager.java:348) at org.apache.doris.mysql.privilege.Auth.getUserId(Auth.java:1950) at org.apache.doris.analysis.CreateUserStmt.<init>(CreateUserStmt.java:94) at org.apache.doris.analysis.CUP$SqlParser$actions.case209(SqlParser.java:51399) at org.apache.doris.analysis.CUP$SqlParser$actions.CUP$SqlParser$do_action(SqlParser.java:19433) at org.apache.doris.analysis.SqlParser.do_action(SqlParser.java:2972) at java_cup.runtime.lr_parser.parse(lr_parser.java:584) at org.apache.doris.common.util.SqlParserUtils.getMultiStmts(SqlParserUtils.java:60) at org.apache.doris.qe.ConnectProcessor.parse(ConnectProcessor.java:516) at org.apache.doris.qe.ConnectProcessor.executeQuery(ConnectProcessor.java:296) at org.apache.doris.qe.ConnectProcessor.handleQuery(ConnectProcessor.java:232) at org.apache.doris.qe.MysqlConnectProcessor.handleQuery(MysqlConnectProcessor.java:177) ```
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
run buildall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by anyone and no changes requested. |
TPC-H: Total hot run time: 41927 ms
|
TPC-DS: Total hot run time: 187044 ms
|
run fe_ut |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
p0 回归case 发现有死锁,先draft |
run buildall |
run buildall |
run buildall |
TPC-H: Total hot run time: 41941 ms
|
TPC-DS: Total hot run time: 188429 ms
|
run buildall |
run buildall |
TPC-H: Total hot run time: 41941 ms
|
TPC-DS: Total hot run time: 186900 ms
|
run buildall |
TPC-H: Total hot run time: 40422 ms
|
TPC-DS: Total hot run time: 187355 ms
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
run performance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
* [fix](user manager) Add rwlock for userManager fix ``` 2024-05-10 14:33:55,005 mysql-nio-pool-67 ERROR An exception occurred processing Appender Sys java.util.ConcurrentModificationException at java.base/java.util.HashMap$HashIterator.nextNode(HashMap.java:1597) at java.base/java.util.HashMap$EntryIterator.next(HashMap.java:1630) at java.base/java.util.HashMap$EntryIterator.next(HashMap.java:1628) at org.apache.logging.log4j.message.ParameterFormatter.appendMap(ParameterFormatter.java:581) at org.apache.logging.log4j.message.ParameterFormatter.appendPotentiallyRecursiveValue(ParameterFormatter.java:512) at org.apache.logging.log4j.message.ParameterFormatter.recursiveDeepToString(ParameterFormatter.java:477) at org.apache.logging.log4j.message.ParameterFormatter.recursiveDeepToString(ParameterFormatter.java:448) at org.apache.logging.log4j.message.ParameterFormatter.formatMessage2(ParameterFormatter.java:191) at org.apache.logging.log4j.message.ParameterizedMessage.formatTo(ParameterizedMessage.java:227) at org.apache.logging.log4j.core.pattern.MessagePatternConverter$SimpleMessagePatternConverter.format(MessagePatternConverter.java:121) at org.apache.logging.log4j.core.layout.PatternLayout$NoFormatPatternSerializer.toSerializable(PatternLayout.java:342) at org.apache.logging.log4j.core.layout.PatternLayout.toText(PatternLayout.java:240) at org.apache.logging.log4j.core.layout.PatternLayout.encode(PatternLayout.java:225) at org.apache.logging.log4j.core.layout.PatternLayout.encode(PatternLayout.java:59) at org.apache.logging.log4j.core.appender.AbstractOutputStreamAppender.directEncodeEvent(AbstractOutputStreamAppender.java:215) at org.apache.logging.log4j.core.appender.AbstractOutputStreamAppender.tryAppend(AbstractOutputStreamAppender.java:208) at org.apache.logging.log4j.core.appender.AbstractOutputStreamAppender.append(AbstractOutputStreamAppender.java:199) at org.apache.logging.log4j.core.appender.RollingFileAppender.append(RollingFileAppender.java:301) at org.apache.logging.log4j.core.config.AppenderControl.tryCallAppender(AppenderControl.java:161) at org.apache.logging.log4j.core.config.AppenderControl.callAppender0(AppenderControl.java:134) at org.apache.logging.log4j.core.config.AppenderControl.callAppenderPreventRecursion(AppenderControl.java:125) at org.apache.logging.log4j.core.config.AppenderControl.callAppender(AppenderControl.java:89) at org.apache.logging.log4j.core.config.LoggerConfig.callAppenders(LoggerConfig.java:675) at org.apache.logging.log4j.core.config.LoggerConfig.processLogEvent(LoggerConfig.java:633) at org.apache.logging.log4j.core.config.LoggerConfig.log(LoggerConfig.java:616) at org.apache.logging.log4j.core.config.LoggerConfig.log(LoggerConfig.java:552) at org.apache.logging.log4j.core.config.AwaitCompletionReliabilityStrategy.log(AwaitCompletionReliabilityStrategy.java:82) at org.apache.logging.log4j.core.Logger.log(Logger.java:161) at org.apache.logging.log4j.spi.AbstractLogger.tryLogMessage(AbstractLogger.java:2205) at org.apache.logging.log4j.spi.AbstractLogger.logMessageTrackRecursion(AbstractLogger.java:2159) at org.apache.logging.log4j.spi.AbstractLogger.logMessageSafely(AbstractLogger.java:2142) at org.apache.logging.log4j.spi.AbstractLogger.logMessage(AbstractLogger.java:2040) at org.apache.logging.log4j.spi.AbstractLogger.logIfEnabled(AbstractLogger.java:1907) at org.apache.logging.log4j.spi.AbstractLogger.warn(AbstractLogger.java:2789) at org.apache.doris.mysql.privilege.UserManager.getUserId(UserManager.java:348) at org.apache.doris.mysql.privilege.Auth.getUserId(Auth.java:1950) at org.apache.doris.analysis.CreateUserStmt.<init>(CreateUserStmt.java:94) at org.apache.doris.analysis.CUP$SqlParser$actions.case209(SqlParser.java:51399) at org.apache.doris.analysis.CUP$SqlParser$actions.CUP$SqlParser$do_action(SqlParser.java:19433) at org.apache.doris.analysis.SqlParser.do_action(SqlParser.java:2972) at java_cup.runtime.lr_parser.parse(lr_parser.java:584) at org.apache.doris.common.util.SqlParserUtils.getMultiStmts(SqlParserUtils.java:60) at org.apache.doris.qe.ConnectProcessor.parse(ConnectProcessor.java:516) at org.apache.doris.qe.ConnectProcessor.executeQuery(ConnectProcessor.java:296) at org.apache.doris.qe.ConnectProcessor.handleQuery(ConnectProcessor.java:232) at org.apache.doris.qe.MysqlConnectProcessor.handleQuery(MysqlConnectProcessor.java:177) ``` * add log * log * fix * fix again * fix
* [fix](user manager) Add rwlock for userManager fix ``` 2024-05-10 14:33:55,005 mysql-nio-pool-67 ERROR An exception occurred processing Appender Sys java.util.ConcurrentModificationException at java.base/java.util.HashMap$HashIterator.nextNode(HashMap.java:1597) at java.base/java.util.HashMap$EntryIterator.next(HashMap.java:1630) at java.base/java.util.HashMap$EntryIterator.next(HashMap.java:1628) at org.apache.logging.log4j.message.ParameterFormatter.appendMap(ParameterFormatter.java:581) at org.apache.logging.log4j.message.ParameterFormatter.appendPotentiallyRecursiveValue(ParameterFormatter.java:512) at org.apache.logging.log4j.message.ParameterFormatter.recursiveDeepToString(ParameterFormatter.java:477) at org.apache.logging.log4j.message.ParameterFormatter.recursiveDeepToString(ParameterFormatter.java:448) at org.apache.logging.log4j.message.ParameterFormatter.formatMessage2(ParameterFormatter.java:191) at org.apache.logging.log4j.message.ParameterizedMessage.formatTo(ParameterizedMessage.java:227) at org.apache.logging.log4j.core.pattern.MessagePatternConverter$SimpleMessagePatternConverter.format(MessagePatternConverter.java:121) at org.apache.logging.log4j.core.layout.PatternLayout$NoFormatPatternSerializer.toSerializable(PatternLayout.java:342) at org.apache.logging.log4j.core.layout.PatternLayout.toText(PatternLayout.java:240) at org.apache.logging.log4j.core.layout.PatternLayout.encode(PatternLayout.java:225) at org.apache.logging.log4j.core.layout.PatternLayout.encode(PatternLayout.java:59) at org.apache.logging.log4j.core.appender.AbstractOutputStreamAppender.directEncodeEvent(AbstractOutputStreamAppender.java:215) at org.apache.logging.log4j.core.appender.AbstractOutputStreamAppender.tryAppend(AbstractOutputStreamAppender.java:208) at org.apache.logging.log4j.core.appender.AbstractOutputStreamAppender.append(AbstractOutputStreamAppender.java:199) at org.apache.logging.log4j.core.appender.RollingFileAppender.append(RollingFileAppender.java:301) at org.apache.logging.log4j.core.config.AppenderControl.tryCallAppender(AppenderControl.java:161) at org.apache.logging.log4j.core.config.AppenderControl.callAppender0(AppenderControl.java:134) at org.apache.logging.log4j.core.config.AppenderControl.callAppenderPreventRecursion(AppenderControl.java:125) at org.apache.logging.log4j.core.config.AppenderControl.callAppender(AppenderControl.java:89) at org.apache.logging.log4j.core.config.LoggerConfig.callAppenders(LoggerConfig.java:675) at org.apache.logging.log4j.core.config.LoggerConfig.processLogEvent(LoggerConfig.java:633) at org.apache.logging.log4j.core.config.LoggerConfig.log(LoggerConfig.java:616) at org.apache.logging.log4j.core.config.LoggerConfig.log(LoggerConfig.java:552) at org.apache.logging.log4j.core.config.AwaitCompletionReliabilityStrategy.log(AwaitCompletionReliabilityStrategy.java:82) at org.apache.logging.log4j.core.Logger.log(Logger.java:161) at org.apache.logging.log4j.spi.AbstractLogger.tryLogMessage(AbstractLogger.java:2205) at org.apache.logging.log4j.spi.AbstractLogger.logMessageTrackRecursion(AbstractLogger.java:2159) at org.apache.logging.log4j.spi.AbstractLogger.logMessageSafely(AbstractLogger.java:2142) at org.apache.logging.log4j.spi.AbstractLogger.logMessage(AbstractLogger.java:2040) at org.apache.logging.log4j.spi.AbstractLogger.logIfEnabled(AbstractLogger.java:1907) at org.apache.logging.log4j.spi.AbstractLogger.warn(AbstractLogger.java:2789) at org.apache.doris.mysql.privilege.UserManager.getUserId(UserManager.java:348) at org.apache.doris.mysql.privilege.Auth.getUserId(Auth.java:1950) at org.apache.doris.analysis.CreateUserStmt.<init>(CreateUserStmt.java:94) at org.apache.doris.analysis.CUP$SqlParser$actions.case209(SqlParser.java:51399) at org.apache.doris.analysis.CUP$SqlParser$actions.CUP$SqlParser$do_action(SqlParser.java:19433) at org.apache.doris.analysis.SqlParser.do_action(SqlParser.java:2972) at java_cup.runtime.lr_parser.parse(lr_parser.java:584) at org.apache.doris.common.util.SqlParserUtils.getMultiStmts(SqlParserUtils.java:60) at org.apache.doris.qe.ConnectProcessor.parse(ConnectProcessor.java:516) at org.apache.doris.qe.ConnectProcessor.executeQuery(ConnectProcessor.java:296) at org.apache.doris.qe.ConnectProcessor.handleQuery(ConnectProcessor.java:232) at org.apache.doris.qe.MysqlConnectProcessor.handleQuery(MysqlConnectProcessor.java:177) ``` * add log * log * fix * fix again * fix
fix
Proposed changes
Issue Number: close #xxx
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...