[fix](index) should not use light index change for bloom filter index #35214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
run buildall |
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
|
PR approved by anyone and no changes requested. |
xy720
added
area/bloom-filter-index
xiaokang
pushed a commit
that referenced
this pull request
May 28, 2024
xiaokang
added
usercase
dataroaring
pushed a commit
that referenced
this pull request
May 31, 2024
…#35214) ## Proposed changes Only inverted index support light index change, bitmap and bloomfilter index do not support light index change. Before this pr, if we add or drop bitmap and bloomfilter index, it only do linked schema change, do not rewrite index data for history data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Only inverted index support light index change, bitmap and bloomfilter index do not support light index change.
Before this pr, if we add or drop bitmap and bloomfilter index, it only do linked schema change, do not rewrite index data for history data.
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...