Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](nereids)NullSafeEqualToEqual rule should keep <=> unchanged if it has none-literal child #36521

Merged
merged 1 commit into from
Jun 20, 2024
Merged

[fix](nereids)NullSafeEqualToEqual rule should keep <=> unchanged if it has none-literal child #36521

merged 1 commit into from
Jun 20, 2024

Conversation

starocean999
Copy link
Contributor

convert:
expr <=> null to expr is null
null <=> null to true
null <=> 1 to false
literal <=> literal to literal = literal ( 1 <=> 2 to 1 = 2 )
others are unchanged.

Proposed changes

Issue Number: close #xxx

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@starocean999
Copy link
Contributor Author

run buildall

@starocean999 starocean999 mentioned this pull request Jun 19, 2024
Merged
@doris-robot
Copy link

TPC-H: Total hot run time: 40903 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 327f48298344f15036635d77ef88d84672b197f6, data reload: false

------ Round 1 ----------------------------------
q1	17626	4362	4296	4296
q2	2016	196	198	196
q3	10430	1212	1022	1022
q4	10181	752	745	745
q5	7472	2672	2648	2648
q6	221	138	136	136
q7	959	606	598	598
q8	9226	2076	2067	2067
q9	9021	6504	6523	6504
q10	8963	3682	3698	3682
q11	442	239	235	235
q12	545	233	239	233
q13	18857	2966	2968	2966
q14	269	216	238	216
q15	510	475	470	470
q16	540	377	378	377
q17	963	653	672	653
q18	8420	8044	7893	7893
q19	8032	1360	1318	1318
q20	676	333	355	333
q21	5170	3967	4120	3967
q22	408	355	348	348
Total cold run time: 120947 ms
Total hot run time: 40903 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4648	4457	4270	4270
q2	382	265	256	256
q3	3200	2870	2866	2866
q4	1942	1636	1686	1636
q5	5540	5535	5546	5535
q6	229	131	133	131
q7	2173	1839	1823	1823
q8	3265	3425	3404	3404
q9	8704	8726	8671	8671
q10	4072	3924	3837	3837
q11	587	479	478	478
q12	776	602	631	602
q13	15876	3133	3129	3129
q14	329	285	263	263
q15	516	479	477	477
q16	470	408	433	408
q17	1834	1524	1489	1489
q18	8051	7788	7732	7732
q19	1786	1475	1700	1475
q20	3216	1860	1804	1804
q21	8120	4899	4893	4893
q22	623	568	574	568
Total cold run time: 76339 ms
Total hot run time: 55747 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 172343 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 327f48298344f15036635d77ef88d84672b197f6, data reload: false

query1	817	399	388	388
query2	6324	2368	2285	2285
query3	6410	203	206	203
query4	20649	17285	17301	17285
query5	3748	496	475	475
query6	251	168	167	167
query7	4460	305	297	297
query8	318	324	305	305
query9	8453	2386	2371	2371
query10	555	311	280	280
query11	10535	10143	9957	9957
query12	132	89	94	89
query13	1562	363	370	363
query14	8643	7887	6335	6335
query15	229	194	183	183
query16	7325	260	259	259
query17	1479	557	506	506
query18	1969	274	273	273
query19	189	154	159	154
query20	95	87	81	81
query21	209	128	126	126
query22	4594	4089	4047	4047
query23	33853	33749	33515	33515
query24	11138	2892	2847	2847
query25	605	360	357	357
query26	801	151	150	150
query27	2262	322	323	322
query28	6577	2032	2047	2032
query29	872	622	602	602
query30	281	151	152	151
query31	947	721	738	721
query32	88	53	56	53
query33	762	283	307	283
query34	865	476	469	469
query35	728	646	632	632
query36	1089	942	914	914
query37	137	68	73	68
query38	2863	2764	2762	2762
query39	871	795	798	795
query40	207	129	128	128
query41	57	53	51	51
query42	120	97	98	97
query43	569	563	540	540
query44	1207	725	728	725
query45	204	161	160	160
query46	1069	723	724	723
query47	1858	1763	1805	1763
query48	368	287	307	287
query49	959	420	414	414
query50	779	376	398	376
query51	6780	6533	6592	6533
query52	107	90	95	90
query53	366	286	287	286
query54	883	457	448	448
query55	74	72	74	72
query56	324	262	286	262
query57	1169	1059	1055	1055
query58	254	256	266	256
query59	3373	3133	3067	3067
query60	319	275	274	274
query61	94	94	96	94
query62	615	448	452	448
query63	317	291	298	291
query64	8758	2343	1759	1759
query65	3203	3145	3122	3122
query66	989	329	324	324
query67	15354	15174	14875	14875
query68	4717	542	534	534
query69	584	399	344	344
query70	1185	1091	1106	1091
query71	399	297	292	292
query72	8019	5415	5849	5415
query73	773	320	321	320
query74	5981	5445	5509	5445
query75	3391	2657	2646	2646
query76	2961	919	985	919
query77	654	297	293	293
query78	10357	9730	9790	9730
query79	1860	527	515	515
query80	834	467	523	467
query81	553	221	224	221
query82	1156	106	106	106
query83	244	169	165	165
query84	247	86	92	86
query85	1519	285	278	278
query86	482	328	322	322
query87	3239	3093	3087	3087
query88	3931	2340	2344	2340
query89	476	386	378	378
query90	1835	190	188	188
query91	126	100	101	100
query92	67	58	49	49
query93	2143	506	504	504
query94	1202	189	189	189
query95	410	336	312	312
query96	598	271	267	267
query97	3252	3078	3083	3078
query98	204	211	197	197
query99	1347	843	851	843
Total cold run time: 268807 ms
Total hot run time: 172343 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.05 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 327f48298344f15036635d77ef88d84672b197f6, data reload: false

query1	0.04	0.03	0.03
query2	0.08	0.04	0.04
query3	0.23	0.06	0.05
query4	1.66	0.10	0.10
query5	0.51	0.49	0.49
query6	1.13	0.72	0.72
query7	0.02	0.02	0.01
query8	0.05	0.05	0.04
query9	0.55	0.49	0.47
query10	0.54	0.56	0.56
query11	0.16	0.11	0.12
query12	0.15	0.12	0.11
query13	0.59	0.58	0.59
query14	0.76	0.78	0.80
query15	0.85	0.84	0.85
query16	0.37	0.38	0.36
query17	1.05	1.03	1.01
query18	0.22	0.25	0.26
query19	1.91	1.78	1.73
query20	0.02	0.01	0.01
query21	15.43	0.64	0.64
query22	4.68	7.03	2.21
query23	18.22	1.37	1.28
query24	2.07	0.21	0.23
query25	0.15	0.09	0.08
query26	0.26	0.18	0.18
query27	0.09	0.07	0.09
query28	13.19	1.02	1.01
query29	12.65	3.32	3.31
query30	0.26	0.06	0.07
query31	2.84	0.40	0.39
query32	3.27	0.47	0.48
query33	2.86	2.90	2.98
query34	17.09	4.42	4.49
query35	4.52	4.46	4.49
query36	0.66	0.47	0.49
query37	0.17	0.15	0.16
query38	0.16	0.14	0.15
query39	0.04	0.04	0.04
query40	0.17	0.16	0.14
query41	0.10	0.04	0.04
query42	0.05	0.05	0.05
query43	0.05	0.04	0.04
Total cold run time: 109.87 s
Total hot run time: 31.05 s

@starocean999 starocean999 marked this pull request as ready for review June 20, 2024 01:26
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jun 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

morrySnow pushed a commit that referenced this pull request Jun 20, 2024
@starocean999
[fix](nereids)NullSafeEqualToEqual rule should keep <=> unchanged if …
64a94e8 
…it has none-literal child (#36523)

pick from master #36521

convert:
expr <=> null to expr is null
null <=> null to true
null <=> 1 to false
literal <=> literal to literal = literal ( 1 <=> 2 to 1 = 2 )
others are unchanged.
@starocean999 starocean999 merged commit 9c7ec37 into apache:master Jun 20, 2024
27 of 30 checks passed
iszhangpch pushed a commit to iszhangpch/doris-p that referenced this pull request Jun 21, 2024
@starocean999 @iszhangpch
[fix](nereids)NullSafeEqualToEqual rule should keep <=> unchanged if …
ad0fd71 
…it has none-literal child (apache#36521)

convert:
 expr <=> null to expr is null
 null <=> null to true
 null <=> 1 to false
 literal <=> literal to literal = literal ( 1 <=> 2 to 1 = 2 )
others are unchanged.
dataroaring pushed a commit that referenced this pull request Jun 21, 2024
@starocean999 @dataroaring
[fix](nereids)NullSafeEqualToEqual rule should keep <=> unchanged if …
b61134b 
…it has none-literal child (#36521)

convert:
 expr <=> null to expr is null
 null <=> null to true
 null <=> 1 to false
 literal <=> literal to literal = literal ( 1 <=> 2 to 1 = 2 )
others are unchanged.
@morningman morningman mentioned this pull request Jun 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@englefly englefly englefly approved these changes

@morrySnow morrySnow morrySnow approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.4-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@starocean999 @doris-robot @englefly @morrySnow