support for cluster can acquire multi be in same host and fixed some issues #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
August 25, 2017 17:38
imay
reviewed
Aug 25, 2017
| @@ -155,7 +155,7 @@ | |||
| ERR_CLUSTER_NAME_NULL(5041, new byte[] {'4', '2', '0', '0', '0'}, "No cluster name"), | |||
| ERR_CLUSTER_NO_PERMISSIONS(5042, new byte[] {'4', '2', '0', '0', '0'}, "No permissions"), | |||
| ERR_CLUSTER_CREATE_ISTANCE_NUM_ERROR(5043, new byte[] {'4', '2', '0', '0', '0'}, | |||
| "Instance num can't be less than 0"), | |||
| "Instance num can't be less than or equal 0"), | |||
There was a problem hiding this comment.
can't be less than nor equal with 0
There was a problem hiding this comment.
这个确定吗？我怎么查了这么写没错啊
imay
requested changes
Aug 25, 2017
| } | ||
| builder.addColumn(new Column(title, ColumnType.createVarchar(30))); | ||
| } | ||
| return builder.build(); |
There was a problem hiding this comment.
这里用其他地方的静态对象生成的，避免重复吧。
There was a problem hiding this comment.
这个没啥重复的吧？因为你每次build出来的内容都一样，那么写成一个静态的对象直接返回是没问题的
| @@ -85,7 +85,7 @@ public static String getDbNameFromFullName(String db) { | |||
| * @return | |||
| */ | |||
| public static String getUsrNameFromFullName(String usr) { | |||
| if (checkName(usr)) { | |||
| if (!checkName(usr)) { | |||
There was a problem hiding this comment.
这里难道不应该是checkName不符合后，返回的是参数而不是null么？
There was a problem hiding this comment.
这个我改下，应该返回参数更合理些。
imay
requested changes
Aug 26, 2017
| } | ||
| builder.addColumn(new Column(title, ColumnType.createVarchar(30))); | ||
| } | ||
| return builder.build(); |
There was a problem hiding this comment.
这个没啥重复的吧？因为你每次build出来的内容都一样，那么写成一个静态的对象直接返回是没问题的
| // Copyright 2017 The Apache Software Foundation | ||
| // Modifications copyright (C) 2017, Baidu.com, Inc. | ||
|
|
||
| // Licensed to the Apache Software Foundation (ASF) under one |
stdpain
pushed a commit
to stdpain/incubator-doris
that referenced
this pull request
Jul 5, 2021
HappenLee
added a commit
to HappenLee/incubator-doris
that referenced
this pull request
Jul 15, 2021
HappenLee
added a commit
to HappenLee/incubator-doris
that referenced
this pull request
Sep 7, 2021
3 tasks
starocean999
pushed a commit
to starocean999/incubator-doris
that referenced
this pull request
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.