Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clang-format script #4934

Merged
merged 1 commit into from Nov 28, 2020
Merged

Add clang-format script #4934

merged 1 commit into from Nov 28, 2020

Conversation

sduzh
Copy link
Contributor

@sduzh sduzh commented Nov 20, 2020

run build-support/check-format.sh to check cpp styles;
run build-support/clang-format.sh to fix cpp style issues;

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • [] Bugfix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] Documentation Update (if none of the other choices apply)
  • Code refactor (Modify the code structure, format the code, etc...)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • [] I have create an issue on (Fix #ISSUE), and have described the bug/feature there in detail
  • [] Compiling and unit tests pass locally with my changes
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] If this change need a document change, I have updated the document
  • [] Any dependent changes have been merged

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!
Could you please add a README file under build-support to explain how to use these scripts?
And better to update the developer-guide/format-code.md document.

@morningman morningman added kind/chore Issues or PRs related to compile and install kind/feature Categorizes issue or PR as related to a new feature. labels Nov 20, 2020
@sduzh
Copy link
Contributor Author

sduzh commented Nov 28, 2020

Nice work!
Could you please add a README file under build-support to explain how to use these scripts?
And better to update the developer-guide/format-code.md document.

updated

run build-support/check-format.sh to check cpp styles;
run build-support/clang-format.sh to fix cpp style issues;
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman merged commit d7225d6 into apache:master Nov 28, 2020
@yangzhg yangzhg mentioned this pull request Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/chore Issues or PRs related to compile and install kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants